Repository navigation
Update common-protos versions and add Dataproc documentation - #2252
Merged
Merged
Conversation
thesamet
marked this pull request as ready for review
October 11, 2026 01:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The common-protos page still advertises old package versions and ScalaPB 0.9/0.10 examples. Update it to match scalapb/common-protos#271:
2.78.0-1, Pub/Sub1.157.0-0, PGV1.3.3-1, and newly added Dataproc4.96.0-0.footeremitted by the table generator.Publication gate: keep this PR in draft until all four stable releases (24 Scala/ScalaPB variants) are available on Maven Central. The build-0 common-protos and PGV releases failed before upload because of the root snapshot version. Build-1 retries use the fix in scalapb/common-protos#272; Pub/Sub and Dataproc follow in sequence. Snapshots are published, but these examples intentionally use the stable coordinates.
Validation:
docs/scalafmtCheckpasses.docs/mdoc --include common-protos.mdpasses; all eight generated examples checked for exact coordinates.docs/mdochits the existing Spark example's JDK 17java.nioaccess error insparksql.md.yarn install --frozen-lockfilepasses.yarn buildis blocked by the existing output-path mismatch: Docusaurus expectsdocs/target/mdoc, while sbt 2 writestarget/out/jvm/scala-2.12.21/docs/mdoc.