Repository navigation
Restore Met Museum search with bounded v1.1 pagination - #116
Open
jonathanlli wants to merge 2 commits into
Open
jonathanlli wants to merge 2 commits into
jonathanlli wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore Met Museum search after retirement of
/public/collection/v1/searchon October 1, 2026. Keep the benchmark'smetmuseum-mcp@0.9.2pin, tool names, argument schemas, and normal text output unchanged.The latest published adapter (1.0.0) still uses the retired path and additionally changes the interface, so a version bump alone does not fix the outage.
Changes
NODE_OPTIONS./v1.1/search, preserving query filters.Verification
sunflowers, 1,815 IDs forcat(multiple pages), and 727 IDs forHercules holding a club(multiple pages).Compatibility caveat
The new provider backend changes matching and ordering, and caps accessible search results at 10,000. This repair restores availability, not exact historical search equivalence. Broad queries must be narrowed rather than silently truncated. Deployments must rebuild the image (or explicitly mount the compatibility file and updated template); changing source alone does not modify an existing image.
Provider documentation: https://metmuseum.github.io/#migrating-from-v1search


Confidence Score: 5/5
The follow-up changes appear safe to merge.Summary
Restores Met Museum search through a search-only preload while keeping the pinned adapter and tool interface.
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Pinned Met adapter fetch] --> B{Exact old search GET?} B -->|No| C[Original fetch unchanged] B -->|Yes| D[Fetch v1.1 pages under one deadline] D --> E{Complete and valid?} E -->|More pages needed| D E -->|Yes| F[Return total and all IDs] E -->|Failure or result limit exceeded| G[Return HTTP failure or throw]Reviews (2) · Last reviewed commit: "Strengthen Met empty-search and shared-d..." · Reviewed by Greptile