feat: add CROC_PORT and CROC_PORTS env vars#1099
Open
hangone wants to merge 2 commits intoschollz:mainfrom
Open
feat: add CROC_PORT and CROC_PORTS env vars#1099hangone wants to merge 2 commits intoschollz:mainfrom
hangone wants to merge 2 commits intoschollz:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds environment-variable configuration for relay ports and updates the Docker healthcheck/docs so containers remain healthy when custom relay ports are used (Fixes #1096).
Changes:
- Add
CROC_PORTS/CROC_PORTenv var support for therelaysubcommand flags. - Update Docker
HEALTHCHECKto probe ports derived fromCROC_PORTS/CROC_PORTinstead of hardcoded9009. - Document the new environment variables in the Docker relay section of the README.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/cli/cli.go |
Adds EnvVars bindings for relay --ports and --port flags. |
Dockerfile |
Makes healthcheck port(s) configurable via CROC_PORTS/CROC_PORT. |
README.md |
Documents how to run the relay container with custom ports using the new env vars. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CROC_PORTSandCROC_PORTenvironment variables for therelaysubcommand, matching the pattern used byCROC_PASS,CROC_RELAY, etc.Fixes #1096