Skip to content

feat: add CROC_PORT and CROC_PORTS env vars#1099

Open
hangone wants to merge 2 commits intoschollz:mainfrom
hangone:add-croc-port-env-vars
Open

feat: add CROC_PORT and CROC_PORTS env vars#1099
hangone wants to merge 2 commits intoschollz:mainfrom
hangone:add-croc-port-env-vars

Conversation

@hangone
Copy link
Copy Markdown

@hangone hangone commented May 7, 2026

  • Add CROC_PORTS and CROC_PORT environment variables for the relay subcommand, matching the pattern used by CROC_PASS, CROC_RELAY, etc.
  • Update Docker healthcheck to dynamically use these env vars instead of hardcoded port 9009
  • Document the new env vars in README

Fixes #1096

Copilot AI review requested due to automatic review settings May 7, 2026 06:37
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds environment-variable configuration for relay ports and updates the Docker healthcheck/docs so containers remain healthy when custom relay ports are used (Fixes #1096).

Changes:

  • Add CROC_PORTS / CROC_PORT env var support for the relay subcommand flags.
  • Update Docker HEALTHCHECK to probe ports derived from CROC_PORTS / CROC_PORT instead of hardcoded 9009.
  • Document the new environment variables in the Docker relay section of the README.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/cli/cli.go Adds EnvVars bindings for relay --ports and --port flags.
Dockerfile Makes healthcheck port(s) configurable via CROC_PORTS/CROC_PORT.
README.md Documents how to run the relay container with custom ports using the new env vars.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Dockerfile Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: container healthcheck fails when custom ports are specified for relay

2 participants