clear ship registry after mission#7523
Draft
Goober5000 wants to merge 1 commit into
Draft
Conversation
Create a `ship_level_close()` function and call it from `game_level_close()`. Among other tasks, this clears the ship registry to prevent SEXPs or scripts from obtaining references to ships that have been deleted. Follow-up to scp-fs2open#7522.
Goober5000
added
fix
Contributor
Author
|
This is actually not going to work as written, because the debriefing sexp evaluation needs to access the ship registry. EDIT: Maybe the way to do this is to replace ShipStatus::PRESENT with something else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a
ship_level_close()function and call it fromgame_level_close(). Among other tasks, this clears the ship registry to prevent SEXPs or scripts from obtaining references to ships that have been deleted.Follow-up to #7522.