Skip to content

Expose the separator parameter added upstream to parse_qs and parse_qsl#167

Open
Gallaecio wants to merge 5 commits into
scrapy:masterfrom
Gallaecio:query-separator
Open

Expose the separator parameter added upstream to parse_qs and parse_qsl#167
Gallaecio wants to merge 5 commits into
scrapy:masterfrom
Gallaecio:query-separator

Conversation

@Gallaecio

@Gallaecio Gallaecio commented Mar 12, 2021

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Mar 20, 2021

Copy link
Copy Markdown

Codecov Report

Merging #167 (6a48367) into master (a6e8c8d) will decrease coverage by 0.32%.
The diff coverage is 88.88%.

❗ Current head 6a48367 differs from pull request most recent head a8e50d2. Consider uploading reports for the commit a8e50d2 to get more accurate results

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
- Coverage   96.14%   95.82%   -0.33%     
==========================================
  Files           8        8              
  Lines         493      503      +10     
  Branches       92       92              
==========================================
+ Hits          474      482       +8     
- Misses          9       10       +1     
- Partials       10       11       +1     
Impacted Files Coverage Δ
w3lib/url.py 97.89% <88.88%> (-0.79%) ⬇️

@hugovk

hugovk commented Sep 1, 2021

Copy link
Copy Markdown
Contributor

#168 says:

Once merged, we can also merge #167

Time to resolve conflicts and merge this?

@Gallaecio

Copy link
Copy Markdown
Member Author

Merged with GitHub’s UI, crossing fingers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants