fixes inconsist variance output between in-memory and dask for groups of size 1#4184
Draft
zboldyga wants to merge 2 commits into
Draft
fixes inconsist variance output between in-memory and dask for groups of size 1#4184zboldyga wants to merge 2 commits into
zboldyga wants to merge 2 commits into
Conversation
zboldyga
commented
Jun 27, 2026
zboldyga
commented
Contributor
- Closes #
- [ x] Tests included or not required because:
- Release notes not necessary because:
… of size 1 (in-memory: 0, dask:NaN). Both now produce NaN, as per numpy (and I think this was the former scanpy value as well? + it's sensible when dof=1 on a single sample). Resolving also entailed adjusting the dask per-block moment computation to prevent NaN from corrupting the variance computation (e.g. if one or more blocks has 1 item). Kind of a pedantic fix, but seemed like an inconsistency that would cause a little confusion / friction in the long run.
Contributor
Author
|
@ilan-gold see commit message for clarity on what this addresses |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4184 +/- ##
=======================================
Coverage 79.72% 79.72%
=======================================
Files 120 120
Lines 12833 12834 +1
=======================================
+ Hits 10231 10232 +1
Misses 2602 2602
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.