ci: fix benchmarks#4190
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4190 +/- ##
==========================================
- Coverage 79.74% 79.73% -0.01%
==========================================
Files 120 120
Lines 12852 12852
==========================================
- Hits 10249 10248 -1
- Misses 2603 2604 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
flying-sheep
commented
Jun 30, 2026
|
No changes in benchmarks. Comparison: https://github.com/scverse/scanpy/compare/d5a745e1258f5ca6a23c6a790f27b40d7ad05418..5ddbf61e1169b09720cf08411f13e03c6733b7ad More details: https://github.com/scverse/scanpy/pull/4190/checks?check_run_id=84281810960 |
ilan-gold
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like
setup()only reliably runs aftersetup_cacheif there are parameters.So I’m returning something from
setup_cacheto introduce a “parameter”.