Skip to content

ci: fix benchmarks#4190

Merged
flying-sheep merged 4 commits into
mainfrom
fix-benchmarks
Jul 1, 2026
Merged

ci: fix benchmarks#4190
flying-sheep merged 4 commits into
mainfrom
fix-benchmarks

Conversation

@flying-sheep

@flying-sheep flying-sheep commented Jun 30, 2026

Copy link
Copy Markdown
Member

Looks like setup() only reliably runs after setup_cache if there are parameters.

So I’m returning something from setup_cache to introduce a “parameter”.

@flying-sheep flying-sheep added this to the 1.12.3 milestone Jun 30, 2026
@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.73%. Comparing base (d5a745e) to head (5ae983e).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4190      +/-   ##
==========================================
- Coverage   79.74%   79.73%   -0.01%     
==========================================
  Files         120      120              
  Lines       12852    12852              
==========================================
- Hits        10249    10248       -1     
- Misses       2603     2604       +1     
Flag Coverage Δ
hatch-test.low-vers 78.79% <ø> (ø)
hatch-test.pre 79.60% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

Comment thread benchmarks/benchmarks/preprocessing_counts.py Outdated
@flying-sheep flying-sheep self-assigned this Jun 30, 2026
@scverse-benchmark

scverse-benchmark Bot commented Jun 30, 2026

Copy link
Copy Markdown

@flying-sheep flying-sheep marked this pull request as ready for review July 1, 2026 10:45
@flying-sheep flying-sheep merged commit c71485f into main Jul 1, 2026
16 checks passed
@flying-sheep flying-sheep deleted the fix-benchmarks branch July 1, 2026 10:45
@flying-sheep flying-sheep modified the milestones: 1.12.3, 1.13.0 Jul 1, 2026
@scverse scverse deleted a comment from lumberbot-app Bot Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants