feat(htsget): c4gh-encrypted streams - #214
Merged
Merged
Conversation
cmdoret
marked this pull request as ready for review
July 8, 2026 14:52
almutlue
approved these changes
Jul 9, 2026
almutlue
left a comment
almutlue
left a comment
Member
There was a problem hiding this comment.
Nice, looks good and I agree with the scope.
Co-authored-by: almutlue <43293149+almutlue@users.noreply.github.com>
Co-authored-by: almutlue <43293149+almutlue@users.noreply.github.com>
Co-authored-by: almutlue <43293149+almutlue@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
More details in the specification document.
Limitations⚠️
crypt4gh.lib.decryptwhich decrypts the whole file -> we are storing the whole decrypted file on disk -> not proper streaming. crypt4gh has other functions to decrypt specific parts, but I suggest to move to these once we have proper streaming support implemented e.g. after refactor(htsget): use htslurp as htsget client #215 .Note
Tests are not fully human and a bit convoluted overkill. I left them, but I would suggest to drop some of them and replace with end-to-end testing if that makes sense.