-
Notifications
You must be signed in to change notification settings - Fork 5
eli/dupeCodeFix #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Elijah-Destigni
wants to merge
7
commits into
main
Choose a base branch
from
eli/dupeCode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
eli/dupeCodeFix #560
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1361cb8
fix
Elijah-Destigni a25df1d
update prepare-tests workdir param to accept subdirectory name
Elijah-Destigni 50c1733
fix: add DOCKER_CONFIG, runAfter, and AWS cleanup guard to ansible pi…
Elijah-Destigni e76a535
replace inline prepare-tests taskSpec with external taskRef
Elijah-Destigni d074ccf
replace inline prepare-molecule-tests and aws-cleanup taskSpecs with …
Elijah-Destigni a735a2c
Merge branch 'main' of github.com:securesign/pipelines into eli/dupeCode
Elijah-Destigni 557c028
fix: avoid referencing skipped install-tas step results in prepare-tests
Elijah-Destigni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,159 @@ | ||
| apiVersion: tekton.dev/v1 | ||
| kind: Task | ||
| metadata: | ||
| name: prepare-tests | ||
| spec: | ||
| description: | | ||
| Prepares the ephemeral test environment by getting cluster credentials, | ||
| installing Keycloak for OIDC, and optionally installing TAS components. | ||
| params: | ||
| - name: eaasSpaceSecretRef | ||
| type: string | ||
| description: Secret reference for EaaS space credentials | ||
| - name: clusterName | ||
| type: string | ||
| description: Name of the ephemeral cluster | ||
| - name: workdir | ||
| type: string | ||
| description: Subdirectory within the source-code workspace (e.g., "operator" or "tas-operator") | ||
| - name: cluster-platform | ||
| type: string | ||
| default: "hypershift" | ||
| description: Cluster platform type | ||
| - name: tas-namespace | ||
| type: string | ||
| default: "trusted-artifact-signer" | ||
| description: Namespace for TAS deployment | ||
| - name: install-tas | ||
| type: string | ||
| default: "false" | ||
| description: Whether to install TAS components (true/false) | ||
| results: | ||
| - name: oidc-hostname | ||
| type: string | ||
| description: Keycloak OIDC hostname | ||
| - name: oidc-issuer-url | ||
| type: string | ||
| description: Keycloak OIDC issuer URL | ||
| - name: fulcio-url | ||
| type: string | ||
| description: Fulcio service URL (only when install-tas=true) | ||
| - name: tsa-url | ||
| type: string | ||
| description: TSA service URL (only when install-tas=true) | ||
| - name: tuf-url | ||
| type: string | ||
| description: TUF service URL (only when install-tas=true) | ||
| - name: rekor-url | ||
| type: string | ||
| description: Rekor service URL (only when install-tas=true) | ||
| - name: rekor-ui-url | ||
| type: string | ||
| description: Rekor UI service URL (only when install-tas=true) | ||
| workspaces: | ||
| - name: source-code | ||
| description: Workspace containing operator source code | ||
| volumes: | ||
| - name: credentials | ||
| emptyDir: {} | ||
| steps: | ||
| - name: get-kubeconfig | ||
| ref: | ||
| resolver: git | ||
| params: | ||
| - name: url | ||
| value: https://github.com/konflux-ci/build-definitions.git | ||
| - name: revision | ||
| value: main | ||
| - name: pathInRepo | ||
| value: stepactions/eaas-get-ephemeral-cluster-credentials/0.1/eaas-get-ephemeral-cluster-credentials.yaml | ||
| params: | ||
| - name: eaasSpaceSecretRef | ||
| value: $(params.eaasSpaceSecretRef) | ||
| - name: clusterName | ||
| value: $(params.clusterName) | ||
| - name: credentials | ||
| value: credentials | ||
| - name: install-keycloak | ||
| ref: | ||
| resolver: git | ||
| params: | ||
| - name: url | ||
| value: https://github.com/securesign/pipelines.git | ||
| - name: revision | ||
| value: main | ||
| - name: pathInRepo | ||
| value: stepactions/integration-test/install-keycloak.yaml | ||
| params: | ||
| - name: credentials | ||
| value: credentials | ||
| - name: KUBECONFIG | ||
| value: $(steps.get-kubeconfig.results.kubeconfig) | ||
| - name: workdir | ||
| value: "$(workspaces.source-code.path)/$(params.workdir)" | ||
| - name: cluster-platform | ||
| value: $(params.cluster-platform) | ||
| - name: install-tas | ||
| ref: | ||
| resolver: git | ||
| params: | ||
| - name: url | ||
| value: https://github.com/securesign/pipelines.git | ||
| - name: revision | ||
| value: main | ||
| - name: pathInRepo | ||
| value: stepactions/integration-test/install-tas.yaml | ||
| params: | ||
| - name: credentials | ||
| value: credentials | ||
| - name: KUBECONFIG | ||
| value: $(steps.get-kubeconfig.results.kubeconfig) | ||
| - name: workdir | ||
| value: "$(workspaces.source-code.path)/$(params.workdir)" | ||
| - name: tas-namespace | ||
| value: $(params.tas-namespace) | ||
| - name: OIDC_ISSUER_URL | ||
| value: $(steps.install-keycloak.results.oidc-issuer-url) | ||
| when: | ||
| - input: "$(params.install-tas)" | ||
| operator: in | ||
| values: ["true"] | ||
| - name: set-results | ||
| image: quay.io/redhat-appstudio/konflux-test:stable | ||
| env: | ||
| - name: OIDC_HOSTNAME | ||
| value: "$(steps.install-keycloak.results.oidc-hostname)" | ||
| - name: OIDC_ISSUER_URL | ||
| value: "$(steps.install-keycloak.results.oidc-issuer-url)" | ||
| - name: INSTALL_TAS | ||
| value: "$(params.install-tas)" | ||
| - name: FULCIO_URL | ||
| value: "$(steps.install-tas.results.fulcio-url)" | ||
| - name: TSA_URL | ||
| value: "$(steps.install-tas.results.tsa-url)" | ||
| - name: TUF_URL | ||
| value: "$(steps.install-tas.results.tuf-url)" | ||
| - name: REKOR_URL | ||
| value: "$(steps.install-tas.results.rekor-url)" | ||
| - name: REKOR_UI_URL | ||
| value: "$(steps.install-tas.results.rekor-ui-url)" | ||
| script: | | ||
| #!/bin/sh | ||
| set -e | ||
|
|
||
| echo -n "$OIDC_HOSTNAME" > $(results.oidc-hostname.path) | ||
| echo -n "$OIDC_ISSUER_URL" > $(results.oidc-issuer-url.path) | ||
|
|
||
| if [ "$INSTALL_TAS" = "true" ]; then | ||
| echo -n "$FULCIO_URL" > $(results.fulcio-url.path) | ||
| echo -n "$TSA_URL" > $(results.tsa-url.path) | ||
| echo -n "$TUF_URL" > $(results.tuf-url.path) | ||
| echo -n "$REKOR_URL" > $(results.rekor-url.path) | ||
| echo -n "$REKOR_UI_URL" > $(results.rekor-ui-url.path) | ||
| else | ||
| echo -n "" > $(results.fulcio-url.path) | ||
| echo -n "" > $(results.tsa-url.path) | ||
| echo -n "" > $(results.tuf-url.path) | ||
| echo -n "" > $(results.rekor-url.path) | ||
| echo -n "" > $(results.rekor-ui-url.path) | ||
| fi | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you created a new Task but I do not see any usage of it.