feat(external-links): add Simkl media link#3121
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a Simkl external link and logo to ExternalLinkBlock: imports ChangesSimkl External Link Addition
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@u61d as stated in our contribution guide, can you rebase your PRs on develop instead of merging develop into it? |
gauthier-th
left a comment
There was a problem hiding this comment.
A screenshot would also have been useful.
e4f9829 to
52079dd
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/ExternalLinkBlock/index.tsx`:
- Line 121: The href builds a query with imdbId unencoded which can break or
allow tampering; update the ExternalLinkBlock (where href is constructed) to
URL-encode the imdbId (use encodeURIComponent on the imdbId variable) before
interpolating into the Simkl redirect query string so the final URL is safe and
well-formed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0ec3eb64-27e6-47a7-8e12-66eff4753850
⛔ Files ignored due to path filters (1)
src/assets/services/simkl.svgis excluded by!**/*.svg
📒 Files selected for processing (1)
src/components/ExternalLinkBlock/index.tsx
52079dd to
0d4e806
Compare
Description
Adds a Simkl link to the external links row on movie and series detail pages.
How Has This Been Tested?
git diff --checkScreenshots / Logs (if applicable)
Checklist:
pnpm buildpnpm i18n:extractSummary by CodeRabbit