Skip to content

feat(external-links): add Simkl media link#3121

Open
u61d wants to merge 1 commit into
seerr-team:developfrom
u61d:feat/simkl-external-link
Open

feat(external-links): add Simkl media link#3121
u61d wants to merge 1 commit into
seerr-team:developfrom
u61d:feat/simkl-external-link

Conversation

@u61d

@u61d u61d commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Description

Adds a Simkl link to the external links row on movie and series detail pages.

How Has This Been Tested?

  • Ran eslint, prettier check, client typecheck, build, and git diff --check
  • Checked the example Simkl redirect URL from the issue resolves to the expected Simkl page

Screenshots / Logs (if applicable)

simkl-icon

Checklist:

  • I have read and followed the contribution guidelines.
  • Disclosed any use of AI (see our policy)
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

Summary by CodeRabbit

  • New Features
    • Added an external Simkl link for supported media (excludes person profiles). Opens in a new tab for quick access to related movies and TV shows.
  • Style
    • Adjusted spacing between external links for improved responsive layout on smaller screens.

@u61d u61d requested a review from a team as a code owner June 5, 2026 02:43
@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 631b24d3-134c-42aa-9460-4cdb5eb8c366

📥 Commits

Reviewing files that changed from the base of the PR and between 52079dd and 0d4e806.

⛔ Files ignored due to path filters (1)
  • src/assets/services/simkl.svg is excluded by !**/*.svg
📒 Files selected for processing (1)
  • src/components/ExternalLinkBlock/index.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/components/ExternalLinkBlock/index.tsx

📝 Walkthrough

Walkthrough

Adds a Simkl external link and logo to ExternalLinkBlock: imports SimklLogo, adjusts spacing classes to space-x-2 sm:space-x-5, and conditionally renders a Simkl anchor to https://api.simkl.com/redirect?to=Simkl&imdb=${encodeURIComponent(imdbId)} when imdbId exists and mediaType !== 'person'.

Changes

Simkl External Link Addition

Layer / File(s) Summary
Simkl external link import and rendering
src/components/ExternalLinkBlock/index.tsx
Imports SimklLogo, updates container spacing to space-x-2 sm:space-x-5, and adds conditional rendering of a Simkl external anchor (when imdbId exists and mediaType !== 'person') linking to api.simkl.com/redirect with the encoded IMDb ID, opening in a new tab and rendering the logo with aria-label="Simkl".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

  • seerr-team/seerr#2136: Also modifies ExternalLinkBlock/index.tsx to conditionally render external links based on mediaType and IMDb presence.

Suggested reviewers

  • gauthier-th
  • 0xSysR3ll
  • M0NsTeRRR

Poem

🐰 A Simkl hop, a tiny cheer,
The logo shows when IMDb is near.
Not for people, only shows and film,
A link that opens in a browser's brim.
Hop on, little rabbit, give a happy trill!

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat(external-links): add Simkl media link' clearly and concisely describes the main change: adding a Simkl external link to the external links component.
Linked Issues check ✅ Passed The implementation adds a Simkl link with the logo that opens the correct redirect URL format when imdbId is present and mediaType is not 'person', meeting all coding requirements from issue #2817.
Out of Scope Changes check ✅ Passed All changes are limited to the ExternalLinkBlock component to add Simkl link functionality; spacing adjustment from space-x-5 to space-x-2 sm:space-x-5 is a reasonable responsive design modification in scope with the new feature.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gauthier-th

Copy link
Copy Markdown
Member

@u61d as stated in our contribution guide, can you rebase your PRs on develop instead of merging develop into it?

@gauthier-th gauthier-th left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A screenshot would also have been useful.

Comment thread src/components/ExternalLinkBlock/index.tsx Outdated
@u61d u61d force-pushed the feat/simkl-external-link branch from e4f9829 to 52079dd Compare June 5, 2026 13:57

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/components/ExternalLinkBlock/index.tsx`:
- Line 121: The href builds a query with imdbId unencoded which can break or
allow tampering; update the ExternalLinkBlock (where href is constructed) to
URL-encode the imdbId (use encodeURIComponent on the imdbId variable) before
interpolating into the Simkl redirect query string so the final URL is safe and
well-formed.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0ec3eb64-27e6-47a7-8e12-66eff4753850

📥 Commits

Reviewing files that changed from the base of the PR and between 03c611b and 52079dd.

⛔ Files ignored due to path filters (1)
  • src/assets/services/simkl.svg is excluded by !**/*.svg
📒 Files selected for processing (1)
  • src/components/ExternalLinkBlock/index.tsx

Comment thread src/components/ExternalLinkBlock/index.tsx Outdated
@u61d u61d force-pushed the feat/simkl-external-link branch from 52079dd to 0d4e806 Compare June 5, 2026 14:36
@seerr-automation-bot seerr-automation-bot added this to the v3.4.0 milestone Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add external SIMKL link on media pages

4 participants