Skip to content

fix(evmrpc): don't charge an innocent client's per-IP bucket on mid-read budget exhaustion - #3935

Merged
amir-deris merged 10 commits into
mainfrom
amir/plt-780-address-ottersec-feedback
Aug 25, 2026
Merged

fix(evmrpc): don't charge an innocent client's per-IP bucket on mid-read budget exhaustion#3935
amir-deris merged 10 commits into
mainfrom
amir/plt-780-address-ottersec-feedback

Removed unused return value

2ad70de
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 17, 2026 in 0s

58.51% (-1.00%) compared to f0faa48

View this Pull Request on Codecov

58.51% (-1.00%) compared to f0faa48

Details

Codecov Report

❌ Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.51%. Comparing base (f0faa48) to head (2ad70de).

Files with missing lines Patch % Lines
evmrpc/rate_limit_middleware.go 33.33% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3935      +/-   ##
==========================================
- Coverage   59.50%   58.51%   -1.00%     
==========================================
  Files        2326     2230      -96     
  Lines      198890   188338   -10552     
==========================================
- Hits       118359   110208    -8151     
+ Misses      69285    67727    -1558     
+ Partials    11246    10403     -843     
Files with missing lines Coverage Δ
evmrpc/request_limiter.go 91.44% <100.00%> (+2.95%) ⬆️
evmrpc/rate_limit_middleware.go 89.77% <33.33%> (+0.54%) ⬆️

... and 96 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.