Skip to content
This repository was archived by the owner on Jan 20, 2026. It is now read-only.

Update default seid coin type to 60 #597

Open
dssei wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Update default seid coin type to 60 #597

Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
e887ada
chore: forge init
dssei Apr 29, 2025
8621059
forge install: forge-std
dssei Apr 29, 2025
da6726d
Merge branch 'main' of github.com:sei-protocol/sei-cosmos
dssei Aug 7, 2025
9fac641
- Change the default type of coin to 60
dssei Aug 8, 2025
c64595c
- get rid of redundant code
dssei Aug 8, 2025
17b7823
remove unintended change
dssei Aug 8, 2025
59f63bb
remove unintended change 2
dssei Aug 8, 2025
4854668
- update TestBeach32ifPbKey test
dssei Aug 8, 2025
d6aff7d
- update TestBeach32ifPbKey test 2
dssei Aug 8, 2025
80505b8
- update ledger tests
dssei Aug 8, 2025
2bdcf9c
- further updates
dssei Aug 8, 2025
c45d94f
- update expected keys
dssei Aug 8, 2025
f90d442
- update expected keys 2
dssei Aug 9, 2025
f93b29c
- update expected keys 3
dssei Aug 9, 2025
7774955
- update expected keys 4
dssei Aug 9, 2025
b8c65f7
- update expected keys 5
dssei Aug 9, 2025
cc7c20e
- update expected keys 6
dssei Aug 9, 2025
ab20603
- update expected keys 7
dssei Aug 9, 2025
d881225
- update expected keys 8
dssei Aug 9, 2025
b1cfdaf
- update expected keys 9
dssei Aug 9, 2025
a290186
- update expected keys 10
dssei Aug 9, 2025
b73bff1
- update expected keys
dssei Aug 11, 2025
a0385b2
Merge branch 'main' of github.com:sei-protocol/sei-cosmos into seid_c…
dssei Aug 11, 2025
497ae5a
- update expected keys in all tests
dssei Aug 11, 2025
2aeb05f
- update the warning wording
dssei Aug 11, 2025
07b5a63
Merge branch 'main' into seid_coin_type_60_as_default
dssei Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion client/keys/add.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,9 @@ func runAddCmd(ctx client.Context, cmd *cobra.Command, args []string, inBuf *buf
// Hide mnemonic from output
showMnemonic = false
mnemonic = ""
fmt.Fprintln(cmd.ErrOrStderr(), "\n**Important** Default coin type has been changed to ETH type 60. "+
"Your address will be different if it was created with previous default ATOM coin type. "+

@philipsu522 philipsu522 Aug 11, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this comment correct? does "ATOM" coin type make more sense or "118"

@dssei dssei Aug 11, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both are correct. Updated the wording to include ATOM(118), so both are mentioned.

"Try using '--coin-type 118' flag for recovery.")
}

return printCreate(cmd, info, showMnemonic, mnemonic, outputFormat)
Expand Down Expand Up @@ -316,7 +319,6 @@ func printCreate(cmd *cobra.Command, info keyring.Info, showMnemonic bool, mnemo
}

cmd.Println(string(jsonString))

default:
return fmt.Errorf("invalid output format %s", outputFormat)
}
Expand Down
16 changes: 8 additions & 8 deletions crypto/keyring/keyring_ledger_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (
func TestInMemoryCreateLedger(t *testing.T) {
kb := NewInMemory()

ledger, err := kb.SaveLedgerKey("some_account", hd.Secp256k1, "cosmos", 118, 3, 1)
ledger, err := kb.SaveLedgerKey("some_account", hd.Secp256k1, "cosmos", 60, 3, 1)

if err != nil {
require.Error(t, err)
Expand All @@ -28,7 +28,7 @@ func TestInMemoryCreateLedger(t *testing.T) {

// The mock is available, check that the address is correct
pubKey := ledger.GetPubKey()
expectedPkStr := "PubKeySecp256k1{03602C0CB4D8C0081FEE794BDE96E7B95FA16F2B5283B764AC070584327B2C7202}"
expectedPkStr := "PubKeySecp256k1{02522FC5F8F6C109A7D167871FCC74AAC406DF47F4F0E54BA212D9DFEEFBD86C58}"
require.Equal(t, expectedPkStr, pubKey.String())

// Check that restoring the key gets the same results
Expand All @@ -42,7 +42,7 @@ func TestInMemoryCreateLedger(t *testing.T) {

path, err := restoredKey.GetPath()
require.NoError(t, err)
require.Equal(t, "m/44'/118'/3'/0/1", path.String())
require.Equal(t, "m/44'/60'/3'/0/1", path.String())
}

// TestSignVerify does some detailed checks on how we sign and validate
Expand All @@ -53,7 +53,7 @@ func TestSignVerifyKeyRingWithLedger(t *testing.T) {
kb, err := New("keybasename", "test", dir, nil)
require.NoError(t, err)

i1, err := kb.SaveLedgerKey("key", hd.Secp256k1, "cosmos", 118, 0, 0)
i1, err := kb.SaveLedgerKey("key", hd.Secp256k1, "cosmos", 60, 0, 0)
if err != nil {
require.Equal(t, "ledger nano S: support for ledger devices is not available in this executable", err.Error())
t.Skip("ledger nano S: support for ledger devices is not available in this executable")
Expand Down Expand Up @@ -91,11 +91,11 @@ func TestAltKeyring_SaveLedgerKey(t *testing.T) {
require.NoError(t, err)

// Test unsupported Algo
_, err = keyring.SaveLedgerKey("key", notSupportedAlgo{}, "cosmos", 118, 0, 0)
_, err = keyring.SaveLedgerKey("key", notSupportedAlgo{}, "cosmos", 60, 0, 0)
require.Error(t, err)
require.Contains(t, err.Error(), ErrUnsupportedSigningAlgo.Error())

ledger, err := keyring.SaveLedgerKey("some_account", hd.Secp256k1, "cosmos", 118, 3, 1)
ledger, err := keyring.SaveLedgerKey("some_account", hd.Secp256k1, "cosmos", 60, 3, 1)
if err != nil {
require.Equal(t, "ledger nano S: support for ledger devices is not available in this executable", err.Error())
t.Skip("ledger nano S: support for ledger devices is not available in this executable")
Expand All @@ -105,7 +105,7 @@ func TestAltKeyring_SaveLedgerKey(t *testing.T) {
// The mock is available, check that the address is correct
require.Equal(t, "some_account", ledger.GetName())
pubKey := ledger.GetPubKey()
expectedPkStr := "PubKeySecp256k1{03602C0CB4D8C0081FEE794BDE96E7B95FA16F2B5283B764AC070584327B2C7202}"
expectedPkStr := "PubKeySecp256k1{02522FC5F8F6C109A7D167871FCC74AAC406DF47F4F0E54BA212D9DFEEFBD86C58}"
require.Equal(t, expectedPkStr, pubKey.String())

// Check that restoring the key gets the same results
Expand All @@ -119,5 +119,5 @@ func TestAltKeyring_SaveLedgerKey(t *testing.T) {

path, err := restoredKey.GetPath()
require.NoError(t, err)
require.Equal(t, "m/44'/118'/3'/0/1", path.String())
require.Equal(t, "m/44'/60'/3'/0/1", path.String())
}
78 changes: 39 additions & 39 deletions crypto/ledger/ledger_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,36 +22,36 @@ func TestErrorHandling(t *testing.T) {
}

func TestPublicKeyUnsafe(t *testing.T) {
path := *hd.NewFundraiserParams(0, sdk.CoinType, 0)
path := *hd.NewFundraiserParams(0, sdk.GetConfig().GetCoinType(), 0)
priv, err := NewPrivKeySecp256k1Unsafe(path)
require.NoError(t, err)
checkDefaultPubKey(t, priv)
}

func checkDefaultPubKey(t *testing.T, priv types.LedgerPrivKey) {
require.NotNil(t, priv)
expectedPkStr := "PubKeySecp256k1{034FEF9CD7C4C63588D3B03FEB5281B9D232CBA34D6F3D71AEE59211FFBFE1FE87}"
require.Equal(t, "eb5ae98721034fef9cd7c4c63588d3b03feb5281b9d232cba34d6f3d71aee59211ffbfe1fe87",
expectedPkStr := "PubKeySecp256k1{021853D93524119EEB31AB0B06F1DCB068F84943BB230DFA10B1292F47AF643575}"
require.Equal(t, "eb5ae98721021853d93524119eeb31ab0b06f1dcb068f84943bb230dfa10b1292f47af643575",
fmt.Sprintf("%x", cdc.Amino.MustMarshalBinaryBare(priv.PubKey())),
"Is your device using test mnemonic: %s ?", testdata.TestMnemonic)
require.Equal(t, expectedPkStr, priv.PubKey().String())
addr := sdk.AccAddress(priv.PubKey().Address()).String()
require.Equal(t, "cosmos1w34k53py5v5xyluazqpq65agyajavep2rflq6h",
require.Equal(t, "cosmos1ndgvlye77dmuct2ncr4m8ghmfkwp7p8slz6zxm",
addr, "Is your device using test mnemonic: %s ?", testdata.TestMnemonic)
}

func TestPublicKeyUnsafeHDPath(t *testing.T) {
expectedAnswers := []string{
"PubKeySecp256k1{034FEF9CD7C4C63588D3B03FEB5281B9D232CBA34D6F3D71AEE59211FFBFE1FE87}",
"PubKeySecp256k1{0260D0487A3DFCE9228EEE2D0D83A40F6131F551526C8E52066FE7FE1E4A509666}",
"PubKeySecp256k1{03A2670393D02B162D0ED06A08041E80D86BE36C0564335254DF7462447EB69AB3}",
"PubKeySecp256k1{033222FC61795077791665544A90740E8EAD638A391A3B8F9261F4A226B396C042}",
"PubKeySecp256k1{03F577473348D7B01E7AF2F245E36B98D181BC935EC8B552CDE5932B646DC7BE04}",
"PubKeySecp256k1{0222B1A5486BE0A2D5F3C5866BE46E05D1BDE8CDA5EA1C4C77A9BC48D2FA2753BC}",
"PubKeySecp256k1{0377A1C826D3A03CA4EE94FC4DEA6BCCB2BAC5F2AC0419A128C29F8E88F1FF295A}",
"PubKeySecp256k1{031B75C84453935AB76F8C8D0B6566C3FCC101CC5C59D7000BFC9101961E9308D9}",
"PubKeySecp256k1{038905A42433B1D677CC8AFD36861430B9A8529171B0616F733659F131C3F80221}",
"PubKeySecp256k1{038BE7F348902D8C20BC88D32294F4F3B819284548122229DECD1ADF1A7EB0848B}",
"PubKeySecp256k1{021853D93524119EEB31AB0B06F1DCB068F84943BB230DFA10B1292F47AF643575}",
"PubKeySecp256k1{022374F2DACD71042B5A888E3839E4BA54752AD6A51D35B54F6ABB899C4329D4BF}",
"PubKeySecp256k1{03B7B924449C6C983CCA4CF01D7AC53811874C384D1EB18E04916EE9486AE89023}",
"PubKeySecp256k1{037795D6F3A390A2B83838DEE4F7DDBCE7FC9B745516B1F3031D858BCC5044B0A3}",
"PubKeySecp256k1{033729F993AE4D3347454A0D37D13C6E3484E7DC7DE7A63DDB4BCA556CCA3886E1}",
"PubKeySecp256k1{025FEB9BB0D950EFACAEBC163F17E76FAA4984B3FF3D41DD06DB79B9EEBBD930F9}",
"PubKeySecp256k1{02E59347ED32D311543F1E82B4467684DC4995EEC4700437386E668D3D9E14C1E0}",
"PubKeySecp256k1{039D92D20650624E2C4A8CAE0421154FC59F885E9518D337BC2105DF8BF13E151B}",
"PubKeySecp256k1{03BE014D2A23A2D46ED95201DDA9D685DA0086B1A2978E3AC770E03E1C19A778F3}",
"PubKeySecp256k1{0325E57703629DB24D61697147674FCB10B94ACA0136A89D37C00FC5CFD31B443A}",
}

const numIters = 10
Expand All @@ -60,7 +60,7 @@ func TestPublicKeyUnsafeHDPath(t *testing.T) {

// Check with device
for i := uint32(0); i < 10; i++ {
path := *hd.NewFundraiserParams(0, sdk.CoinType, i)
path := *hd.NewFundraiserParams(0, sdk.GetConfig().GetCoinType(), i)
t.Logf("Checking keys at %v\n", path)

priv, err := NewPrivKeySecp256k1Unsafe(path)
Expand Down Expand Up @@ -94,7 +94,7 @@ func TestPublicKeyUnsafeHDPath(t *testing.T) {
}

func TestPublicKeySafe(t *testing.T) {
path := *hd.NewFundraiserParams(0, sdk.CoinType, 0)
path := *hd.NewFundraiserParams(0, sdk.GetConfig().GetCoinType(), 0)
priv, addr, err := NewPrivKeySecp256k1(path, "cosmos")

require.NoError(t, err)
Expand All @@ -108,29 +108,29 @@ func TestPublicKeySafe(t *testing.T) {

func TestPublicKeyHDPath(t *testing.T) {
expectedPubKeys := []string{
"PubKeySecp256k1{034FEF9CD7C4C63588D3B03FEB5281B9D232CBA34D6F3D71AEE59211FFBFE1FE87}",
"PubKeySecp256k1{0260D0487A3DFCE9228EEE2D0D83A40F6131F551526C8E52066FE7FE1E4A509666}",
"PubKeySecp256k1{03A2670393D02B162D0ED06A08041E80D86BE36C0564335254DF7462447EB69AB3}",
"PubKeySecp256k1{033222FC61795077791665544A90740E8EAD638A391A3B8F9261F4A226B396C042}",
"PubKeySecp256k1{03F577473348D7B01E7AF2F245E36B98D181BC935EC8B552CDE5932B646DC7BE04}",
"PubKeySecp256k1{0222B1A5486BE0A2D5F3C5866BE46E05D1BDE8CDA5EA1C4C77A9BC48D2FA2753BC}",
"PubKeySecp256k1{0377A1C826D3A03CA4EE94FC4DEA6BCCB2BAC5F2AC0419A128C29F8E88F1FF295A}",
"PubKeySecp256k1{031B75C84453935AB76F8C8D0B6566C3FCC101CC5C59D7000BFC9101961E9308D9}",
"PubKeySecp256k1{038905A42433B1D677CC8AFD36861430B9A8529171B0616F733659F131C3F80221}",
"PubKeySecp256k1{038BE7F348902D8C20BC88D32294F4F3B819284548122229DECD1ADF1A7EB0848B}",
"PubKeySecp256k1{021853D93524119EEB31AB0B06F1DCB068F84943BB230DFA10B1292F47AF643575}",
"PubKeySecp256k1{022374F2DACD71042B5A888E3839E4BA54752AD6A51D35B54F6ABB899C4329D4BF}",
"PubKeySecp256k1{03B7B924449C6C983CCA4CF01D7AC53811874C384D1EB18E04916EE9486AE89023}",
"PubKeySecp256k1{037795D6F3A390A2B83838DEE4F7DDBCE7FC9B745516B1F3031D858BCC5044B0A3}",
"PubKeySecp256k1{033729F993AE4D3347454A0D37D13C6E3484E7DC7DE7A63DDB4BCA556CCA3886E1}",
"PubKeySecp256k1{025FEB9BB0D950EFACAEBC163F17E76FAA4984B3FF3D41DD06DB79B9EEBBD930F9}",
"PubKeySecp256k1{02E59347ED32D311543F1E82B4467684DC4995EEC4700437386E668D3D9E14C1E0}",
"PubKeySecp256k1{039D92D20650624E2C4A8CAE0421154FC59F885E9518D337BC2105DF8BF13E151B}",
"PubKeySecp256k1{03BE014D2A23A2D46ED95201DDA9D685DA0086B1A2978E3AC770E03E1C19A778F3}",
"PubKeySecp256k1{0325E57703629DB24D61697147674FCB10B94ACA0136A89D37C00FC5CFD31B443A}",
}

expectedAddrs := []string{
"cosmos1w34k53py5v5xyluazqpq65agyajavep2rflq6h",
"cosmos19ewxwemt6uahejvwf44u7dh6tq859tkyvarh2q",
"cosmos1a07dzdjgjsntxpp75zg7cgatgq0udh3pcdcxm3",
"cosmos1qvw52lmn9gpvem8welghrkc52m3zczyhlqjsl7",
"cosmos17m78ka80fqkkw2c4ww0v4xm5nsu2drgrlm8mn2",
"cosmos1ferh9ll9c452d2p8k2v7heq084guygkn43up9e",
"cosmos10vf3sxmjg96rqq36axcphzfsl74dsntuehjlw5",
"cosmos1cq83av8cmnar79h0rg7duh9gnr7wkh228a7fxg",
"cosmos1dszhfrt226jy5rsre7e48vw9tgwe90uerfyefa",
"cosmos1734d7qsylzrdt05muhqqtpd90j8mp4y6rzch8l",
"cosmos1ndgvlye77dmuct2ncr4m8ghmfkwp7p8slz6zxm",
"cosmos148thdqj6vnkkmsfd58ej4xjuacmqq7qwawg0ak",
"cosmos1dj36dxe0sgxygfya5ghggvrhe92qqwm2xcqhtu",
"cosmos1zhjvvpr8skduawtkz2gqdvpe3w8jj60z637arr",
"cosmos1r3amgzyuktpfzez9gyhj5dnpwm207gc32zcejc",
"cosmos146hlrlypx59e5sl50cfys75zcw6s5mymnqm4dj",
"cosmos1cwus47jk96mpc9t8aczzthwq2eshsfygxhrjlj",
"cosmos17g7vlqppmur95dlcgrflxp3et5f26q3mx5xu86",
"cosmos1nl69yryav4d2rxgwwzanft7frl63pe4ydqxy6x",
"cosmos1sufp46z4jp8v8wse096ytxv0nee3mm2zekjqhf",
}

const numIters = 10
Expand All @@ -139,7 +139,7 @@ func TestPublicKeyHDPath(t *testing.T) {

// Check with device
for i := 0; i < len(expectedAddrs); i++ {
path := *hd.NewFundraiserParams(0, sdk.CoinType, uint32(i))
path := *hd.NewFundraiserParams(0, sdk.GetConfig().GetCoinType(), uint32(i))
t.Logf("Checking keys at %s\n", path)

priv, addr, err := NewPrivKeySecp256k1(path, "cosmos")
Expand Down Expand Up @@ -192,7 +192,7 @@ func TestSignaturesHD(t *testing.T) {
for account := uint32(0); account < 100; account += 30 {
msg := getFakeTx(account)

path := *hd.NewFundraiserParams(account, sdk.CoinType, account/5)
path := *hd.NewFundraiserParams(account, sdk.GetConfig().GetCoinType(), account/5)
t.Logf("Checking signature at %v --- PLEASE REVIEW AND ACCEPT IN THE DEVICE\n", path)

priv, err := NewPrivKeySecp256k1Unsafe(path)
Expand All @@ -209,7 +209,7 @@ func TestSignaturesHD(t *testing.T) {

func TestRealDeviceSecp256k1(t *testing.T) {
msg := getFakeTx(50)
path := *hd.NewFundraiserParams(0, sdk.CoinType, 0)
path := *hd.NewFundraiserParams(0, sdk.GetConfig().GetCoinType(), 0)
priv, err := NewPrivKeySecp256k1Unsafe(path)
require.NoError(t, err)

Expand Down
3 changes: 3 additions & 0 deletions types/address.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ const (
// CoinType is the ATOM coin type as defined in SLIP44 (https://github.com/satoshilabs/slips/blob/master/slip-0044.md)
CoinType = 118

// CoinType60 is the ETH (EVM) coin type as defined in SLIP44 (https://github.com/satoshilabs/slips/blob/master/slip-0044.md)
CoinType60 = 60

// FullFundraiserPath is the parts of the BIP44 HD path that are fixed by
// what we used during the ATOM fundraiser.
FullFundraiserPath = "m/44'/118'/0'/0/0"
Expand Down
4 changes: 2 additions & 2 deletions types/bech32/legacybech32/pk_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ import (

func TestBeach32ifPbKey(t *testing.T) {
require := require.New(t)
path := *hd.NewFundraiserParams(0, sdk.CoinType, 0)
path := *hd.NewFundraiserParams(0, sdk.GetConfig().GetCoinType(), 0)
priv, err := ledger.NewPrivKeySecp256k1Unsafe(path)
require.Nil(err, "%s", err)
require.NotNil(priv)

pubKeyAddr, err := MarshalPubKey(AccPK, priv.PubKey())
require.NoError(err)
require.Equal("cosmospub1addwnpepqd87l8xhcnrrtzxnkql7k55ph8fr9jarf4hn6udwukfprlalu8lgw0urza0",
require.Equal("cosmospub1addwnpepqgv98kf4ysgea6e34v9sduwukp50sj2rhv3sm7ssky5j73a0vs6h2cgfmwy",
pubKeyAddr, "Is your device using test mnemonic: %s ?", testdata.TestMnemonic)
}
2 changes: 1 addition & 1 deletion types/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ func NewConfig() *Config {
fullFundraiserPath: FullFundraiserPath,

purpose: Purpose,
coinType: CoinType,
coinType: CoinType60,
txEncoder: nil,
}
}
Expand Down
Loading