Prevent errors in the run for certain repos#12
Conversation
|
Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project. Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken. 💡 Shall we fix this?This will only take a few moments. First, clone your fork and checkout this branch using the git CLI. Next, set up your real name and email address:
Finally, run one of these commands to add the "Signed-off-by" line to your commits. If you only have one commit so far then run: Check that the message has been added properly by running "git log". |
Signed-off-by: GitHub <rajbos@users.noreply.github.com>
|
Commit has been signed. |
|
Hi @rajbos if you'd like us to accept this PR, please follow the proper sign-off instructions of the DCO using a real email and name. If you don't want to do this, we'll have to close the PR. Alex |
| log.Printf("Listing workflow runs for: %s", repo.GetFullName()) | ||
| if orgName != "" { | ||
| runs, res, err = client.Actions.ListRepositoryWorkflowRuns(ctx, orgName, repo.GetName(), opts) | ||
| if err != nil { |
There was a problem hiding this comment.
I don't think this is a good fix.
You need to look at the specific error and HTTP code and determine if the problem is due to actions being disabled on the repo or something else, and if it's something else, it must continue to fail.
There was a problem hiding this comment.
I've tested this on repos which have actions disabled and get no errors.
Can you share the exact console output and how to reproduce it?
2 participants
I've had this happen in a repo with a private vulnerability disclosure that did not have actions available, and thus broke the entire run. This change fixes that.
I expect the same thing will happen if actions is not enabled (for example on a fork).
Fixes #13