Skip to content

Fix patchipa freezing indefinitely on invalid .mobileprovision #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Fix patchipa freezing indefinitely on invalid .mobileprovision #796

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
789063e
Initial plan
Copilot Apr 12, 2026
5f3206b
Fix _set_bundle_id_from_profile to check security cms return code and…
Copilot Apr 12, 2026
14e813a
Guard temp file removal in finally block with existence check
Copilot Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 21 additions & 25 deletions objection/utils/patchers/ios.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,35 +460,31 @@ def _set_bundle_id_from_profile(self):

_, decoded_location = tempfile.mkstemp('decoded_provision')

# Decode the mobile provision using macOS's security cms tool
delegator.run(self.list2cmdline([
self.required_commands['security']['location'],
'cms', '-D', '-i', self.provision_file,
'-o', decoded_location
]), timeout=self.command_run_timeout)
try:
# Decode the mobile provision using macOS's security cms tool
cms_result = delegator.run(self.list2cmdline([
self.required_commands['security']['location'],
'cms', '-D', '-i', self.provision_file,
'-o', decoded_location
]), timeout=self.command_run_timeout)

# https://stackoverflow.com/a/66820375
# security cms -D -i your.mobileprovision | plutil -extract
# Entitlements.application-identifier xml1 -o - - | grep string |
# sed 's/^<string>[^\.]*\.\(.*\)<\/string>$/\1/g'
c = delegator.run(self.list2cmdline([
'cat', decoded_location
]), timeout=self.command_run_timeout).pipe(self.list2cmdline([
self.required_commands['plutil']['location'],
'-extract', 'Entitlements.application-identifier', 'xml1', '-o', '-', '-'
]), timeout=self.command_run_timeout).pipe(self.list2cmdline([
'grep', 'string'
]), timeout=self.command_run_timeout).pipe(self.list2cmdline([
'sed', r's/^<string>[^\.]*\.\(.*\)<\/string>$/\1/g'
]), timeout=self.command_run_timeout)
if cms_result.return_code != 0:
raise Exception('Failed to decode provisioning profile: {}'.format(cms_result.err))

if len(c.out) > 0:
self.bundle_id = c.out.strip()
# Parse the decoded plist and extract the bundle identifier
with open(decoded_location, 'rb') as f:
parsed_data = plistlib.load(f)

click.secho('Mobile provision bundle identifier is: {}'.format(self.bundle_id), dim=True)
app_id = parsed_data.get('Entitlements', {}).get('application-identifier', '')
if '.' in app_id:
self.bundle_id = app_id.split('.', 1)[1]

# cleanup the temp path
os.remove(decoded_location)
finally:
# cleanup the temp path
if os.path.exists(decoded_location):
os.remove(decoded_location)

click.secho('Mobile provision bundle identifier is: {}'.format(self.bundle_id), dim=True)

def _cleanup_extracted_data(self) -> None:
"""
Expand Down