Repository navigation
Suppress exceptions for aborted requests - #404
Merged
nblumhardt merged 1 commit intoAug 17, 2026
Merged
Conversation
Member
|
Thanks! Current trajectory will have this out in a v11.0 in a couple of months. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #372.
Summary
RequestLoggingMiddlewareno longer attaches an escapingOperationCanceledExceptionorIOExceptionto the completion event whenHttpContext.RequestAbortedis cancelled.The completion event is still emitted, the exception continues to propagate through the middleware pipeline, and exceptions collected through
IDiagnosticContext.SetException()remain attached.Rationale
This follows ASP.NET Core's request-abort handling.
IOExceptionwas included intentionally (aspnetcore#46330 discussion), and the exception is omitted to avoid noisy, non-actionable stack traces (Tratcher's comment).Tests
Tests cover both cancellation exception types, non-aborted cancellation, and preservation of collected exceptions.