Introduce ContextSnapshot#1483
Closed
mcruzdev wants to merge 1 commit into
Closed
Conversation
mcruzdev
force-pushed
the
context-snapshot
branch
from
27bdc6b to
932a160
Compare
Collaborator
|
I would work on a different appoach to fulfill this, lets close this for now |
fjtirado
reviewed
Jun 25, 2026
Comment on lines
-326
to
+331
| if (toCancel != null) { | ||
| toCancel.forEach(t -> t.cancel(true)); | ||
| } | ||
| toCancel.forEach(t -> t.cancel(true)); |
Collaborator
There was a problem hiding this comment.
????????
what happens now if toCancel is null
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Special notes for reviewers:
Additional information (if needed):