Add information about number of tests and subtests#56
Conversation
This is a companion of servo/internal-wpt-dashboard#56 Signed-off-by: Manuel Rego Casasnovas <rego@igalia.com>
|
If this is merged we'll have to also land a change on the website so the new information is used there: servo/servo.org#233 |
nicoburns
left a comment
nicoburns
left a comment
There was a problem hiding this comment.
A comment:
- We could probably leave out the
per_mille_*fields here and compute them on the frontend if we wanted to. It's probably also fine to have them here. My concern is around keeping the filesize small.
A question:
- Is this format backwards compatible with the existing file? If not then we'll need to carefully time merging this with the website PR. (but it looks like it probably is?)
nicoburns
left a comment
nicoburns
left a comment
There was a problem hiding this comment.
A couple of points of note in comments, but this generally looks good and I don't think either are blocking.
mukilan
left a comment
mukilan
left a comment
There was a problem hiding this comment.
Thank you! I have a left comments about logic used for calculation of subtests for historic runs. In addition, I think there are few syntax issues that our linter will complain about. Could you please run npm run lint locally and address those issues?
Yeah, I can do this so the size would be reduced a little bit.
No, it's not backwards compatible, when we land this we should also land #51 |
|
I have uploaded a new version fixing lint and adding a new test for the old vs new runs count, but I need to understand what we want to do there as I'm not sure about the numbers we have now. I haven't yet modified the |
mrego
force-pushed
the
wpt-subtests
branch
2 times, most recently
from
9d04a87 to
4d7d22e
Compare
|
I think the last version covers most of the comments, PTAL. Thanks. Before landing I need to update the website PR, but first I want to get agreement on this one in particular. |
mukilan
left a comment
mukilan
left a comment
There was a problem hiding this comment.
Looks good to me with the latest changes! Thanks!
This modifies the scores.json file so it now provides more data: * total_tests: The total number of tests * total_score: The total scores for the tests * total_subtests: The total number of subtests * total_subtests_passed: The number of subtests that pass This is based on previous work by Delan Azabani at #35. This also creates a new output file scores-last-run.json with only the data of the last run. Co-authored-by: Delan Azabani <dazabani@igalia.com> Signed-off-by: Manuel Rego Casasnovas <rego@igalia.com>
This is a companion of servo/internal-wpt-dashboard#56 Signed-off-by: Manuel Rego Casasnovas <rego@igalia.com>
This is a companion of servo/internal-wpt-dashboard#56 Signed-off-by: Manuel Rego Casasnovas <rego@igalia.com>
This is a companion of servo/internal-wpt-dashboard#56 Co-authored-by: Mukilan Thiyagarajan <mukilan@igalia.com> Signed-off-by: Manuel Rego Casasnovas <rego@igalia.com>
This is a companion of servo/internal-wpt-dashboard#56 Co-authored-by: Mukilan Thiyagarajan <mukilan@igalia.com> Signed-off-by: Manuel Rego Casasnovas <rego@igalia.com>
This is a companion of servo/internal-wpt-dashboard#56 Co-authored-by: Mukilan Thiyagarajan <mukilan@igalia.com> Signed-off-by: Manuel Rego Casasnovas <rego@igalia.com>
|
Just for the record, the size of the generated files:
|
3 participants
Add information about number of tests and subtests
This modifies the scores.json file so it now provides more data:
This is based on previous work by Delan Azabani at #35.
This also creates a new output file scores-last-run.json
with only the data of the last run.