Skip to content

Display ids as decimal, not hexa#20

Open
rakoo wants to merge 1 commit into
shaj13:mainfrom
rakoo:for-pr
Open

Display ids as decimal, not hexa#20
rakoo wants to merge 1 commit into
shaj13:mainfrom
rakoo:for-pr

Conversation

@rakoo

@rakoo rakoo commented Jun 28, 2023

Copy link
Copy Markdown

Reopening !19 properly

@shaj13

shaj13 commented Jul 9, 2023

Copy link
Copy Markdown
Owner

Why do we need this change?
hexa (%x) used to align with etcd logs https://github.com/etcd-io/raft/blob/main/node.go#L370

@shaj13 shaj13 self-requested a review July 9, 2023 14:26
Comment thread controller.go
ctrl, ok := r.ctrls[gid]
if !ok {
return nil, fmt.Errorf("raft: unknown group id %x", gid)
return nil, fmt.Errorf("raft: unknown group id %d", gid)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants