feat!: support parseable URL values#158
Open
charliecreates[bot] wants to merge 4 commits into
Open
Conversation
Owner
|
@CharlieHelps use the pull request template |
Contributor
Author
|
Done — I updated the PR body to use the repository pull request template and kept the |
shellscape
requested changes
Apr 22, 2026
Owner
shellscape
left a comment
shellscape
left a comment
There was a problem hiding this comment.
I see no tests for the myriad of url('...') variants. And since url is producing a Word, the tests should go into the word tests.
Owner
|
@gwynne I was able to get a review in before I had to step away. please review this when able |
shellscape
changed the title
gwynne
suggested changes
Apr 22, 2026
gwynne
left a comment
gwynne
left a comment
There was a problem hiding this comment.
Other than the incomplete test coverage, the rest looks correct to me, and a quick local test shows that it fully covers my use case.
Co-authored-by: Gwynne Raskind <gwynne@darkrainfall.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
If yes, please describe the breakage.
The value of
isUrlis now determined by different conditions, which could break consumers downstream if relying on older behavior and value ofisUrl.Please Describe Your Changes
Resolves #157