feat: detect app version bumps in version-bump#186
Merged
Dominik Grothaus (dgrothaus-sw) merged 2 commits intoJul 24, 2026
Conversation
The `version-bump` action now reads an app's version from `manifest.xml` (`/manifest/meta/version`, via `xmllint`) alongside a plugin's `composer.json`, so `version-bump-notify` also alerts when an app is preparing a release. `composer.json` wins when both are present, and the version-aware comparison and two-ref `git show` model are unchanged.
Dominik Grothaus (dgrothaus-sw)
requested review from
a team and
Dumea Alexandru (alexdumea)
July 23, 2026 08:08
Marcel Brode (marcelbrode)
approved these changes
Jul 23, 2026
Dumea Alexandru (alexdumea)
approved these changes
Jul 24, 2026
Dominik Grothaus (dgrothaus-sw)
deleted the
feat-allow-app-version-notofication
branch
July 24, 2026 08:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
version-bumpdetects a strict version increase for apps as well as plugins: the version is read fromcomposer.json(.version) for plugins and frommanifest.xml(/manifest/meta/version, parsed withxmllint) for apps, preferringcomposer.jsonwhen both are present. Theversion-bump-notifyreusable workflow and its Slack message are extension-neutral, so an app repo wires it up exactly like a plugin but triggers onmanifest.xml.The two-ref
git showmodel, the version-aware comparison and the injection-safe output handling are unchanged; a missing file or version node stays silent while malformed input fails loud. The app path — including a manifest carrying the realxsiroot attributes and the composer-over-manifest precedence — is covered byversion-bump.test.bash.