fix(component-library): remove datepicker positioning override - #1305
Open
Sy Dinh (sydinh) wants to merge 1 commit into
Open
fix(component-library): remove datepicker positioning override#1305Sy Dinh (sydinh) wants to merge 1 commit into
Sy Dinh (sydinh) wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR fixes mt-datepicker menu positioning by removing a CSS override that interfered with Floating UI’s computed coordinates, letting Floating UI fully control placement.
Changes:
- Removed the obsolete
left: 0 !importantfrom.dp--menu-wrapperto prevent overriding Floating UI positioning.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
554
to
555
| filter: drop-shadow(0px 1px 3px #0000000f); | ||
| filter: drop-shadow(0px 1px 3px #0000001a); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Remove the obsolete
left: 0 !importantoverride frommt-datepicker.Why?
The rule overrides the coordinates calculated by Floating UI, causing the datepicker menu to be positioned incorrectly.
How?
Removed the
left: 0 !importantdeclaration from.dp--menu-wrapperand kept Floating UI responsible for positioning.Testing?
git diff --check.Screenshots (optional)
Not applicable.
Anything Else?
N/A