Repository navigation
chore: use youtube-nocookie embeds and drop Twitter widget script - #422
Merged
Merged
Conversation
Switches blog YouTube embeds to youtube-nocookie.com and removes the Twitter widgets.js script. Embedded tweets now render as plain blockquotes with links.
Contributor
|
🐦 Preview of f6d0c99: https://shorebird-website--pr-422-qdy34eus.web.app (expires in 7 days) |
AbhishekDoshi26
left a comment
AbhishekDoshi26
left a comment
Member
There was a problem hiding this comment.
Reviewed the diff. Looks good:
- All 3
youtube.com/embediframes on main are switched; no other YouTube embeds remain, so the narrowedrich-text.cssselector doesn't leave anything without 16:9 sizing. Theadvanced-permissionsiframe sits inside a<div>, so it relies on the attribute selector, and that still matches. - Dropping the
?si=share-tracking params is a nice extra. - Both
widgets.jstags are gone and nothing else loads Twitter scripts. The tweets fall back to.prose.rich-text blockquotestyling and keep their links to the originals. - No CSP/
frame-srcconfig needs updating.
No changes needed.
AbhishekDoshi26
approved these changes
Oct 14, 2026
AbhishekDoshi26
left a comment
AbhishekDoshi26
left a comment
Member
There was a problem hiding this comment.
LGTM. No changes needed (see review above).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
youtube-nocookie.com(3 posts). Updates the matchingrich-text.cssselector so they keep their 16:9 sizing.widgets.jsscript from 2 posts. The embedded tweets render as plain blockquotes with a link to the original.npm run buildpasses.