Fix ON DELETE SET NULL formatting - #134
Open
VrtxOmega wants to merge 1 commit into
Open
Conversation
| terminated("SELECT", end_of_word), | ||
| terminated("SET CURRENT SCHEMA", end_of_word), | ||
| terminated("SET SCHEMA", end_of_word), | ||
| terminated("SET NULL", end_of_word), |
There was a problem hiding this comment.
WARNING: SET DEFAULT is still tokenized as a top-level SET clause
This special-cases SET NULL, but referential actions also allow SET DEFAULT. For ON DELETE SET DEFAULT and ON UPDATE SET DEFAULT, the tokenizer will still match the plain SET branch here, classify it as ReservedTopLevel, and split the foreign-key action across lines again.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 1 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments: None. Files Reviewed (2 files)
Fix these issues in Kilo Cloud Reviewed by gpt-5.4-20260305 · 469,562 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #132.
Summary
SET NULLas a regular reserved phrase so foreign-key actions likeON DELETE SET NULLdo not split atSET.Validation
cargo fmt --checkcargo testON DELETE SET NULLon the column definition line.