feat: add trident-nfs-tools extension for NFS support on Talos#1141
Open
ohauer wants to merge 1 commit into
Open
feat: add trident-nfs-tools extension for NFS support on Talos#1141ohauer wants to merge 1 commit into
ohauer wants to merge 1 commit into
Conversation
Trident's chwrap mechanism shells out to mkdir to create NFS mountpoint directories. Talos Linux does not ship mkdir, causing NFS mounts to fail with exit status 32. This extension provides /usr/local/sbin/mkdir (busybox) on the host, enabling Trident NFS volumes to work on Talos. Upstream fix: NetApp/trident#1152 Related: NetApp/trident#806 Signed-off-by: Oliver Hauer <ohauer@users.noreply.github.com>
Member
|
If there's a PR upstream i would suggest to wait until it's available, it;s not simple to remove an extension once it's published, there's a lot of downstream consumers that would need extra code to handle unpublished extensions |
Member
|
@kevintijssen your opinion? |
Member
I agree with @frezbo. I have tested NFSv4 without any issues so far. I noticed the |
Member
thanks, I put it on hold for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
trident-nfs-toolssystem extension that provides/usr/local/sbin/mkdir(busybox) on the Talos host.Problem
Trident's
chwrapmechanism shells out tomkdirto create NFS mountpoint directories before callingmount.nfs4. Talos Linux does not shipmkdiror any coreutils, causing all NFS mounts to fail:The iSCSI code path uses Go's native
os.MkdirAll()and is not affected. Only the NFS path shells out to the binary.What's Included
/usr/local/sbin/mkdir— busybox multi-call binary (only depends on musl libc)Testing
mkdiris not present on Talos v1.13.x hosts/usr/local/sbin/and will find the binaryextensions-validatorRelated
trident-iscsi-toolsextensionNote
Once Trident PR #1152 is merged (replaces
mkdirshell-out withos.MkdirAll()), this extension will no longer be needed. Until then, it unblocks NFS on Talos.