feat(frontend): allow switching logs inside logs tab#2794
Conversation
|
I think dropdown height is 2 pixels bigger than the input. We can either do |
|
Lets also manually add |
there;s also |
|
@frezbo those ones are part of the service list already @Unix4ever sure but should it be part of the service list? is fixing the backend API the correct fix or shall i just manually hardcode in frontend? hardcoded for now, had to do some regex for parsing and to strip the ANSI colours |
Extract logic to get list of machine services into a useMachineServices composable. Signed-off-by: Edward Sammut Alessi <edward.sammutalessi@siderolabs.com>
Move NodeLogs logic into MachineLogsContainer. This deduplicates the code paths between machine vs service logs, and allows viewing service logs from the machines log tab as well. Signed-off-by: Edward Sammut Alessi <edward.sammutalessi@siderolabs.com>
Allow switching between machine and service logs from inside the logs tab via a dropdown of services Signed-off-by: Edward Sammut Alessi <edward.sammutalessi@siderolabs.com>
utkuozdemir
left a comment
utkuozdemir
left a comment
There was a problem hiding this comment.
Don't count on my review on frontend-specific stuff, but logic-wise I don't see any issues.
We can't add it to the backend response as it's coming from Talos |
|
/m |
5 participants
Allow switching between machine and service logs from inside the logs tab via a dropdown of services. Also includes some refactoring to allow the same behaviour on both machine page and node page.
Closes #2712