Repository navigation
Conversation
Read SIFT_MCP_FEATURE_FLAGS, a JSON object of flag name to variant, and skip the startup fetch when it is set. Invalid JSON falls back to the fetch. Claude-Session: https://claude.ai/code/session_01Ca3FGoRyLiyP2RwgTPHTsP
Contributor
Author
|
dont merge me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
sift-cli mcpreadsSIFT_MCP_FEATURE_FLAGS(a JSON object of flag name to variant, e.g.{"chat-agents-service":"on"}) and skips its startup flag fetch when it is set.create_artifactand the test report tools but keepsupdate_artifact. This was seen in prod.Verification
cargo test -p sift_mcp feature_flagsandcargo test -p sift_cli mcp::pass, including new tests for parsing and for skipping the fetch.cargo clippyshows no new warnings.