Skip to content

Extra-Content-Type header added for declarative config - #3138

Closed
robsunday wants to merge 1 commit into
signalfx:mainfrom
robsunday:fix-for-missing-header-in-prof-exporter
Closed

robsunday wants to merge 1 commit into
signalfx:mainfrom
robsunday:fix-for-missing-header-in-prof-exporter

Conversation

@robsunday

Copy link
Copy Markdown
Contributor

In review of PR 3135 codex detected missing header in already existing code implementing log exporter setup.
While it could be worked around by providing additional header in the YAML, it would be inconsistent with environment configuration and require additional knowledge from the user.
This PR adds Extra-Content-Type=otel-profiling-stacktraces header automatically

@robsunday
robsunday requested review from a team as code owners October 21, 2026 14:04
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T14:08:16.102601Z 8c79c51 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@robsunday
robsunday marked this pull request as draft October 22, 2026 12:36
@breedx-splk

Copy link
Copy Markdown
Contributor

We talked about this and agreed that this isn't necessary. Go ahead and reopen if there's something else that I'm missing. ✌🏻

@github-actions github-actions Bot locked and limited conversation to collaborators Oct 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants