Repository navigation
GDI spec 1.10.0 - #3163
GDI spec 1.10.0#3163
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0447b2ddbd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Map<String, String> config = new HashMap<>(); | ||
|
|
||
| config.put("otel.traces.sampler", "always_on"); | ||
| config.put("otel.attribute.value.length.limit", "12000"); |
There was a problem hiding this comment.
We should consider add this default also for declarative confguration, since it is a security related. I think we should not assume user will put it in declarative config yaml.
There was a problem hiding this comment.
I had the exact same question when I looked at https://github.com/signalfx/gdi-specification/pull/414/changes so I asked @Kielek who didn't give a clear answer. Then I looked at the whole file https://github.com/signalfx/gdi-specification/blob/main/specification/configuration.md#instrumentation-libraries and realized that there are separate sections for environment variable and file based configuration. This limit is only specified in the environment variable section. @Kielek said to that that he'd be supportive for adding this to gdi spec. I interpret this that currently gdi spec does not require this for the declarative config. Since implementing it would be slightly annoying I'm fine with that.
robsunday
left a comment
robsunday
left a comment
There was a problem hiding this comment.
I'm giving the approval with a note that declarative config should also be updated
No description provided.