fix: Invalidate outstanding ICU handles in Wrapper.Cleanup() - #239
Draft
imnasnainaec wants to merge 1 commit into
Draft
imnasnainaec wants to merge 1 commit into
imnasnainaec wants to merge 1 commit into
Conversation
Cleanup() unloaded the ICU libraries but left every outstanding handle pointing into the unloaded module, so using an object created before the call dereferenced freed memory and took down the process with an AccessViolationException that managed code cannot catch. Objects that own a native handle now register with IcuHandleRegistry, and Cleanup() invalidates them before unloading. Using one afterwards throws ObjectDisposedException, and disposing one no longer calls into the unloaded libraries. Handles that were never opened can't go stale, so ResourceBundle.Null and not-yet-initialized break iterators keep working. The types that already used SafeHandle (collator, transliterator, enumerator) share a new SafeIcuHandle base, where SetHandleAsInvalid() makes the interop marshaler do the throwing. The classes that hold a plain IntPtr (BiDi, RuleBasedBreakIterator, RegexMatcher, MessageFormatter, ResourceBundle, Normalizer2) hold it in a NativeHandle instead. Fixes #237 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possibly handles #237
Devin review: https://app.devin.ai/review/sillsdev/icu-dotnet/pull/239