Skip to content

[PB Extension] Remove dev-only changeLexicon command and its menu item - #2691

Merged
imnasnainaec merged 1 commit into
developfrom
chore/remove-dev-lexicon-commands
Sep 25, 2026
Merged

imnasnainaec merged 1 commit into
developfrom
chore/remove-dev-lexicon-commands

Conversation

@imnasnainaec

Copy link
Copy Markdown
Collaborator

Remove the dev-only lexicon switcher before release.

  • Drop the lexicon.changeLexicon command and its handler type. Selection stays sticky: to change a project's lexicon, clear its lexicon.lexiconCode setting.
  • Drop the "Select lexicon..." menu item (which ran that command) and its localized string.
  • Document lexicon.selectLexicon, pointing other extensions to lexicon.openSelector instead.
  • Tighten lexicon.resolveProject's doc, dropping a stale example (restored selector tabs keep their projectId).

Test plan

  • The Scripture editor's lexicon menu no longer shows "Select lexicon...".
  • Clearing lexicon.lexiconCode still makes the next lexicon action open the selector.

🤖 Generated with Claude Code

Also document lexicon.selectLexicon, pointing other extensions to
lexicon.openSelector instead, and tighten lexicon.resolveProject's doc,
dropping a stale example.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 38 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: bb3d033e-a3b1-4eb6-9c26-c7f3c7fe9af9

📥 Commits

Reviewing files that changed from the base of the PR and between b74f17b and 8928172.

📒 Files selected for processing (4)
  • platform.bible-extension/contributions/localizedStrings.json
  • platform.bible-extension/contributions/menus.json
  • platform.bible-extension/src/main.ts
  • platform.bible-extension/src/types/lexicon.d.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@imnasnainaec imnasnainaec self-assigned this Sep 24, 2026
@imnasnainaec
imnasnainaec marked this pull request as ready for review September 24, 2026 21:22
@imnasnainaec
imnasnainaec merged commit 00ee6ac into develop Sep 25, 2026
7 checks passed
@imnasnainaec
imnasnainaec deleted the chore/remove-dev-lexicon-commands branch September 25, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants