[claude] Make viewer UI tests wait until entry rows have loaded - #2697
Merged
Merged
Conversation
ProjectPage.waitFor() asserted zero skeleton rows before any rows had mounted, which passes trivially. Rows then mount as skeletons, and since skeleton rows also have role="row", the final row-count poll passed too, so goto() could return with every row still a skeleton. On WebKit CI that made "adding entry at end increases scroll height" take its baseline 288px too tall (13 initial rows, 100px as skeletons vs ~78px loaded) and fail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reachedNext included review available in 56 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
the
💻 FW Lite
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
myieye
added
the
self-reviewed 👁️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Claude, autonomous]
ProjectPage.waitFor()checked for skeleton rows before any rows existed, sogoto()could return while every row was still a skeleton. On WebKit that made "adding entry at end increases scroll height…" take a baseline 288px too tall (13 rows, 100px as skeletons vs ~78px loaded) and fail, e.g. 4× in a row on #2694.🤖 Generated with Claude Code