Take libpalaso 18, which recovers an abandoned SLDR mutex - #10
Open
johnml1135 wants to merge 2 commits into
Open
johnml1135 wants to merge 2 commits into
johnml1135 wants to merge 2 commits into
Conversation
libpalaso's GlobalMutex let AbandonedMutexException escape, so a process killed while holding the machine-wide SldrCache mutex broke every later writing-system load on the machine, FieldWorks' included: one run of the suite lost 445 tests to it. SIL.Core/SIL.WritingSystems 18.0.0-beta0042 carries libpalaso #1544 (LT-21834), which recovers from the abandonment and replaces the SLDR cache and writing-system files atomically. SIL.LCModel still asks for libpalaso 17, so the pins are now direct rather than only active under a local override. A test pins the new behaviour: it fails on 17.0.0-beta0097 and passes on 18.0.0-beta0042. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A process killed while holding libpalaso's machine-wide
SldrCachemutex made every later writing-system load on the machine fail withAbandonedMutexException— Motif's, and FieldWorks' too — until something took and released it. One run of our suite lost 445 tests to it. libpalaso fixed it in sillsdev/libpalaso#1544 (LT-21834), shipped inSIL.Core/SIL.WritingSystems18.0.0-beta0042; this takes that release.What changes
SilVersions.propspins libpalaso 18.0.0-beta0042.SIL.LCModel(even 11.0.0-beta0182) still asks for 17.x, so theSIL.Core/SIL.WritingSystemspins in five projects are now unconditional instead of applying only under the local-libpalaso override.AbandonedSldrMutexTestspins the new behaviour: it abandons a privately namedGlobalMutexand takes it again. It fails on 17.0.0-beta0097 withAbandonedMutexExceptionand passes on 18.0.0-beta0042. It uses a private name on purpose — abandoning the realSldrCachemutex hangs any other process still on 17.Evidence and risk
./test.ps1 -Configuration Release: 2,021 passed, 0 failed, 40 skipped.SIL.Windows.Forms(ImageCropper, +semver:major Fix unusable ImageCropper crop; RawFormat now MemoryBmp libpalaso#1530), which Motif does not reference; the full suite is the compatibility evidence.🤖 Generated with Claude Code