Figure not printing in module XXA

[philleckrone]

When I create a module that includes a picture in Matthew 2:8, the picture shows in the Preview of the module, but does not print in PTXPrint.

If I print Matthew, the Final SFM shows the following at verse 8:
\v 8 Luego los mandó a Belén y les dijo:
\p —Vayan y averigüen todo lo que puedan acerca de ese niño y, cuando lo sepan todo, avísenme para que yo también pueda ir a adorarle.

However, if I print it as the module (last option), I see this:
\v 8 Luego los mandó a Belén y les dijo:\fig test 1|size="col" ref="2:8" src="CN01632b.tif"\fig*
\p —Vayan y averigüen todo lo que puedan acerca de ese niño y, cuando lo sepan todo, avísenme para que yo también pueda ir a adorarle.

If I choose the XXA book, I see this:
\v 8 Luego los mandó a Belén y les dijo:\zfiga|000*
\p —Vayan y averigüen todo lo que puedan acerca de ese niño y, cuando lo sepan todo, avísenme para que yo también pueda ir a adorarle.

In neither of the last to cases does the picture appear in the PDF. This is an issue that was reported on Support.Bible and I've tested it myself.

PDT15-DefaultPTXprintArchive.zip

[mhosken]

Well there's a philosophical question. Do you want pictures printing in a module?

Does the \vid line set the \id@@@ or not? I suspect not. But what are the implications of changing that because there is no marker inserted to change it back to the module, so the module will think it is MAT up until the next \vid which could be pages away. Alternatively we keep id@@@ as MOD and have the pictures anchored at places like MOD 2:8. But what if there is text from multiple books at 2:8? And then if the same text is inserted twice into a module, do we want the pictures twice?

[philleckrone]

Martin - I guess the answer to the question is YES. Examples of this might be: The Easter Story, The Nativity Story, The Life of Jesus, Any short story from the Bible.
If I create a module and choose to include pictures (option in Paratext) then when it prints, I'd want those pictures included. I'm sure that someone out there might say that they want to include MAT 2:8 two times in the module, but only want the image to occur one time, but I would expect that to be more rare than the case of someone who simply wants to prepare the life of Jesus with pictures.

Thanks for looking at this issue!

[davidg-sil]

• In answer to Martin's qn, \vid|h="Mark" ref="MRK 4:26"\* will set \id@@@ to MRK
• Phil,Martin Unless you tell it not to a single piclist entry will generate a single picture, no matter how often the zfiga id/verse/keyterm appears, so a module including MAT 2:8 twice, with a figure anchored there will only create a picture the first time it was met. (See documentation on \KeepFigure in figures.md to override that default behaviour).
• The \zfiga|000* is worrying, it should be \zfiga|000\* I can't immediately check, because these days archives are getting created without local

[davidg-sil]

Checking what I'm seeing:

1. In the final version of the SFM:
   • No \vid|\* entries
   • \v 8 Luego los mandó a Belén y les dijo:\zfiga|\* Which probably means the zfiga is unmatchable.
2. In the archive, no figures included
3. In the version of the piclist that TeX opens (under local/ptxprint/Default):
   XXA p001=11 test 1|size="col" ref="2:8" srcref="XXA p001=11" (Probably due to no figures in archive)
4. In the log file, when \tracing{T} and ...{m} are enabled:

T> running (cv) triggers XXA0.8(p@rnum reset to 1)
T> Trigger(trigger-XXA0.8) absent
T> settrig@refcv: XXA0.8
m> Firing zfiga
m> mst@nestyle:zfiga ()
m> initmil@stone 
m> start style
m> Immediate start of attributes
m> startmst@nestyle
m> Starting attribute collection
T> runtrigg@rspar[p] XXA0.8=XXA0.8?
T> settrig@refcv: XXA0.8
T> running triggers(par) XXA0.8=2 2, 1
T> Trigger(trigger-XXA0.8=2) absent

This tells me that leaving the module definition and python processing as they currently are, the image can be triggered at XXA0.8 (verse 8) and XXA0.8=2 (2nd paragraph of verse 8).
Alternatively, \vid|ref="MAT 2.0"\* and similar entries could be added to the input at relevant key points, which would replace the XXA0 with MAT2 etc.

The module definition and source files were not included in the archive, only the XXA book. I presume that \vid would be passed through from the definition unmodified.... Note that `\vid|h="The visit of the magi"* should allow theme-based running-headers to be set, too.