Skip to content

Defense-in-depth. #979

Description

@pmachapman

Defense-in-depth. SharedFileUtils.Normalize (src/Machine/src/Serval.Machine.Shared/Utils/SharedFileUtils.cs:5-19) doesn't strip ..; not currently reachable with user input (all callers use server-generated ids) but worth a guard. The langtags.json cache write (LanguageTagParser.cs:42) is not atomic (FileMode.Create directly to the cache path) and can poison the cache if the process dies mid-download.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    • Status
      🔖 Ready

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions