Skip to content

Add planet mapmaker v2 - #1736

Draft
yoshinori-0778 wants to merge 3 commits into
masterfrom
add_planet_mapmaker_v2
Draft

Add planet mapmaker v2#1736
yoshinori-0778 wants to merge 3 commits into
masterfrom
add_planet_mapmaker_v2

Conversation

@yoshinori-0778

Copy link
Copy Markdown
Contributor

This is updated PR of #1706.
Sorry I ended up making new pr. I probably make mistake when I merged lots of commits.

Almost of all comments by Katie and Matthew are addressed. So I would like to review again.

@yoshinori-0778

Copy link
Copy Markdown
Contributor Author

Request to @mhasself:
Could you comment on this? I am happy to modify the scripts if I can use that database.

A note on this. I discovered recently that the extended obsdbs running in your user account do not include calibration observations. It would be good to have those expanded and to make them official. Otherwise we'll keep having parallel implementations pop up.

@yoshinori-0778

Copy link
Copy Markdown
Contributor Author

Questions:

Build and Test shows error because Database written in mapcat is not exsist in the one we are using in this build test. How should I manage this? Can I avoid this by removing from planet_mapmaker.py import * in init.py ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant