depth1 mapcat update - #1740
Open
axf295 wants to merge 1 commit into
Open
Conversation
mapcat's uuid7/datetime/path-rename migrations left this module behind: - ctime/start_time/stop_time were passed as raw unix-time floats into columns mapcat's "Swapping to datetime" migration made datetime, causing session.commit() to raise "SQLite DateTime type only accepts Python datetime and date objects" on the very first commit_depth1_tods call (outside the mapmaking try/except, so it hard-crashes the pipeline before a map is made). - commit_depth1_map passed time_path, a field DepthOneMapTable no longer has (split into start_time_path/mean_time_path/end_time_path). SQLModel silently drops unknown kwargs, so no time-map path was ever recorded. - commit_depth1_tods passed map_name into TODDepthOneTable, which has no such column anymore (association is via a many-to-many relationship through TODToMapTable). The kwarg was silently ignored, so TODs were never actually linked to their map. Verified against a real mapcat db migrated to head: commit succeeds, ctime/start_time/stop_time land as datetimes, mean_time_path is populated, and the TOD<->map relationship is linked in both directions. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Rh1TMcQhLGM8TyQZ947Rvt
axf295
force-pushed
the
mapcat_update
branch
from
September 11, 2026 01:54
e1a5492 to
10376cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used claude to update the relevant mapcat integration per mapcat v0.4.0
mapcat's uuid7/datetime/path-rename migrations left this module behind:
Verified against a real mapcat db migrated to head: commit succeeds, ctime/start_time/stop_time land as datetimes, mean_time_path is populated, and the TOD<->map relationship is linked in both directions.
Claude-Session: https://claude.ai/code/session_01Rh1TMcQhLGM8TyQZ947Rvt