fix FemalesWithChildrenByChildAgeCSfilter - #502
Merged
Conversation
This filter has two issues: - the check it was attempting to perform was incorrectly implemented; - the check it was attempting to perform was not the desired one: it tried to check that all children are in the given age range, whereas checking that any child is in the given range is the desired behaviour. This commit also introduces the new `Filters` "class" which is a collection of static methods to easily build predicates on a `Person`. This will become most useful when introducing the newer APIs currently in development in jasmine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #499
This introduces the filters I've been working on as they're already helpful even without the newer jasmine API I'm currently working on.