Repository navigation
Release: full pipeline on merges + memory/queue hardening - #138
Conversation
- Detect Deploy Targets: a merge commit pushed to origin (the release branch) now marks every target changed — a merge is a release, so all builds, deploys, and the supermemory image publish fire instead of silently shipping nothing - lint: no longer skipped on merge commits to origin; every push to the release branch gets the complete pipeline
|
Warning Review limit reached
Next review available in: 1 minute Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| HEAD_MSG="$(git log -1 --format=%s)" | ||
| if [ "${{ github.event_name }}" = "push" ] && [ "${{ github.ref_name }}" = "origin" ] && [[ "${HEAD_MSG}" == "Merge pull request"* || "${HEAD_MSG}" == "Merge branch"* ]]; then |
There was a problem hiding this comment.
Merge detection misses valid merges
When a merge pushed to origin has a subject such as Merge remote-tracking branch 'origin/origin' into origin, this condition falls through to path-based filtering, causing build, test, and deployment targets to be skipped during the release.
| HEAD_MSG="$(git log -1 --format=%s)" | |
| if [ "${{ github.event_name }}" = "push" ] && [ "${{ github.ref_name }}" = "origin" ] && [[ "${HEAD_MSG}" == "Merge pull request"* || "${HEAD_MSG}" == "Merge branch"* ]]; then | |
| if [ "${{ github.event_name }}" = "push" ] && [ "${{ github.ref_name }}" = "origin" ] && [ "$(git rev-list --parents -n 1 HEAD | wc -w)" -gt 2 ]; then |
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/ci.yml
Line: 50-51
Comment:
**Merge detection misses valid merges**
When a merge pushed to `origin` has a subject such as `Merge remote-tracking branch 'origin/origin' into origin`, this condition falls through to path-based filtering, causing build, test, and deployment targets to be skipped during the release.
```suggestion
if [ "${{ github.event_name }}" = "push" ] && [ "${{ github.ref_name }}" = "origin" ] && [ "$(git rev-list --parents -n 1 HEAD | wc -w)" -gt 2 ]; then
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.| # Runs on every PR and every push to the release branch (origin) — | ||
| # merge commits are not skipped so releases always get the full pipeline. | ||
| if: github.event_name == 'pull_request' || github.ref_name == 'origin' |
There was a problem hiding this comment.
Non-origin pushes lose lint coverage
When any non-origin branch is pushed, this condition skips lint despite the workflow's documented fast-feedback contract, so lint failures are not reported until a pull request is opened.
| # Runs on every PR and every push to the release branch (origin) — | |
| # merge commits are not skipped so releases always get the full pipeline. | |
| if: github.event_name == 'pull_request' || github.ref_name == 'origin' | |
| # Runs on every PR and push, including release merges and fast-feedback branch pushes. | |
| if: github.event_name == 'pull_request' || github.event_name == 'push' |
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/ci.yml
Line: 106-108
Comment:
**Non-origin pushes lose lint coverage**
When any non-origin branch is pushed, this condition skips lint despite the workflow's documented fast-feedback contract, so lint failures are not reported until a pull request is opened.
```suggestion
# Runs on every PR and push, including release merges and fast-feedback branch pushes.
if: github.event_name == 'pull_request' || github.event_name == 'push'
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Release branch merge.
Includes:
Greptile Summary
This release updates CI so recognized merge commits on origin run every quality and deployment target, and bumps the package version to 0.6.69.
Confidence Score: 3/5
The PR should not merge until release detection handles every merge commit and lint coverage is restored for non-origin pushes.
Some valid release-branch merge subjects bypass full-target selection and can skip deployments, while the new lint condition also removes the workflow's documented fast-feedback lint run from feature and development branch pushes.
Files Needing Attention: .github/workflows/ci.yml
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Workflow event] --> B{Pull request or origin?} B -->|No| C[Type-check only under changed conditions] B -->|Yes| D[Detect deploy targets] D --> E{Push to origin and recognized merge subject?} E -->|Yes| F[Enable every target] E -->|No| G[Select targets from changed paths] F --> H[Lint, type-check, build, and tests] G --> H H --> I{Quality checks pass?} I -->|Yes, origin push| J[Run selected deployments and releases] I -->|No| K[Stop pipeline]Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "fix[CI]: Run the full pipeline on releas..." | Re-trigger Greptile