Drop tough-cookie and har-validator dependencies#159
Merged
Conversation
tough-cookie was a 300 KB RFC 6265 / public-suffix library used only to split name=value; path=/; domain=...; expires=... strings into their parts. A small inline parser handles everything the HAR output needs and preserves tough-cookie's leading-.-strip on the domain attribute so output stays byte-identical for the test fixtures. har-validator has been deprecated upstream for over a year and only appeared in one place — a validator.har(har) smoke-check inside the test loop. The surrounding ava assertions already cover HAR shape, so removing the call drops the dev dep (and its transitive ajv + har-schema chain) without losing real coverage. Runtime dep tree shrinks from debug + tough-cookie + tldts + tldts-core to just debug + ms. Co-authored-by: Claude noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tough-cookie was a 300 KB RFC 6265 / public-suffix library used only to
split name=value; path=/; domain=...; expires=... strings into their
parts. A small inline parser handles everything the HAR output needs and
preserves tough-cookie's leading-.-strip on the domain attribute so
output stays byte-identical for the test fixtures.
har-validator has been deprecated upstream for over a year and only
appeared in one place — a validator.har(har) smoke-check inside the
test loop. The surrounding ava assertions already cover HAR shape, so
removing the call drops the dev dep (and its transitive ajv + har-schema
chain) without losing real coverage.
Runtime dep tree shrinks from debug + tough-cookie + tldts + tldts-core
to just debug + ms.
Co-authored-by: Claude noreply@anthropic.com