Repository navigation
Update PyTorch to 2.15.0, Python to 3.14 - #1183
Conversation
- Add torch 2.15.0 to CI and docs - Remove 2.11.0 - Bump 2.14.0 to 2.14.1 From checking the changelog, there should be no need for further changes in skorch.
- Python 3.10 is EOL and removed - Python 3.14 is added - Update pandas test
Sacred cannot be imported, as it raises this error: > AttributeError: module 'pkgutil' has no attribute 'find_loader' Not sure if this is going to be fixed, sacred hasn't been updated in over a year at the time of writing.
thomasjpfan
left a comment
There was a problem hiding this comment.
sacred hasn't been updated for over a year, so unsure if it's ever going to be fixed
If it makes things easier, I would even be okay with dropping sacred.
Otherwise LGTM
| git clone https://github.com/skorch-dev/skorch.git | ||
| cd skorch | ||
| conda create -n skorch-env python=3.10 | ||
| conda create -n skorch-env python=3.12 |
There was a problem hiding this comment.
Should this be 3.11?
BTW I'm okay with even setting it to the newest support Python version.
There was a problem hiding this comment.
I went with 3.12 here for consistency, e.g. with the README:
Lines 186 to 197 in 066927b
Not sure if anyone is using the Sacred callback, but I think as long as it still works (i.e. until Python 3.13 is EOL), the cost of keeping it around is minimal, so I'd just leave it for the time being. |
torch:
From checking the changelog, there should be no need for further changes in skorch.
Python
pyproject.tomlAttributeError: module 'pkgutil' has no attribute 'find_loader'); sacred hasn't been updated for over a year, so unsure if it's ever going to be fixed