Dev

[sky22333]

Summary by CodeRabbit

• New Features
  • Added English and Simplified Chinese language support with in-app language selection.
  • Improved screen mirroring with surface recreation, video reset, and VP8/VP9 codec support.
  • Added clearer local application names and improved app list presentation.
  • Updated the bundled mirroring service to version 4.1.
• Bug Fixes
  • Improved Fastboot response validation and connection handling.
  • Prevented connection leaks during mirror-session startup failures.
  • Improved file, download, discovery, and device operation error handling.
• Documentation
  • Documented mirror-session continuity during backgrounding and surface recreation.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 98d9bc56-6998-452e-9ec3-3367095b9187

📥 Commits

Reviewing files that changed from the base of the PR and between 5a172c3 and 5189c78.

📒 Files selected for processing (94)

• .gitignore
• app/build.gradle.kts
• app/src/main/AndroidManifest.xml
• app/src/main/assets/scrcpy/scrcpy-server-v4.0
• app/src/main/assets/scrcpy/scrcpy-server-v4.1
• app/src/main/java/com/sky22333/skyadb/AppServices.kt
• app/src/main/java/com/sky22333/skyadb/MainActivity.kt
• app/src/main/java/com/sky22333/skyadb/adb/FastbootOtgManager.kt
• app/src/main/java/com/sky22333/skyadb/adb/KadbManager.kt
• app/src/main/java/com/sky22333/skyadb/apps/AppDisplayEnricher.kt
• app/src/main/java/com/sky22333/skyadb/data/AppSettingsStore.kt
• app/src/main/java/com/sky22333/skyadb/diagnostics/DiagnosticFormatter.kt
• app/src/main/java/com/sky22333/skyadb/diagnostics/DiagnosticLog.kt
• app/src/main/java/com/sky22333/skyadb/discovery/AdbMdnsDiscovery.kt
• app/src/main/java/com/sky22333/skyadb/discovery/AdbScanModels.kt
• app/src/main/java/com/sky22333/skyadb/discovery/AndroidAdbMdnsDiscovery.kt
• app/src/main/java/com/sky22333/skyadb/discovery/NetworkInfoProvider.kt
• app/src/main/java/com/sky22333/skyadb/discovery/ScanRangeParser.kt
• app/src/main/java/com/sky22333/skyadb/download/DownloadTask.kt
• app/src/main/java/com/sky22333/skyadb/download/NetworkDownloadManager.kt
• app/src/main/java/com/sky22333/skyadb/files/LocalFileManager.kt
• app/src/main/java/com/sky22333/skyadb/i18n/AppLanguage.kt
• app/src/main/java/com/sky22333/skyadb/i18n/AppText.kt
• app/src/main/java/com/sky22333/skyadb/localapps/LocalAppExporter.kt
• app/src/main/java/com/sky22333/skyadb/localapps/LocalAppIcons.kt
• app/src/main/java/com/sky22333/skyadb/model/AdbDevice.kt
• app/src/main/java/com/sky22333/skyadb/model/DeviceInfo.kt
• app/src/main/java/com/sky22333/skyadb/repository/AdbRepository.kt
• app/src/main/java/com/sky22333/skyadb/scrcpy/MirrorCoordinateMapper.kt
• app/src/main/java/com/sky22333/skyadb/scrcpy/MirrorQualityPreset.kt
• app/src/main/java/com/sky22333/skyadb/scrcpy/ScrcpyAudioDecoder.kt
• app/src/main/java/com/sky22333/skyadb/scrcpy/ScrcpyConstants.kt
• app/src/main/java/com/sky22333/skyadb/scrcpy/ScrcpyControlClient.kt
• app/src/main/java/com/sky22333/skyadb/scrcpy/ScrcpyProtocol.kt
• app/src/main/java/com/sky22333/skyadb/scrcpy/ScrcpyRepository.kt
• app/src/main/java/com/sky22333/skyadb/scrcpy/ScrcpyServerManager.kt
• app/src/main/java/com/sky22333/skyadb/scrcpy/ScrcpySession.kt
• app/src/main/java/com/sky22333/skyadb/scrcpy/ScrcpyVideoDecoder.kt
• app/src/main/java/com/sky22333/skyadb/ui/AdbManagerApp.kt
• app/src/main/java/com/sky22333/skyadb/ui/apps/AppsScreen.kt
• app/src/main/java/com/sky22333/skyadb/ui/apps/AppsViewModel.kt
• app/src/main/java/com/sky22333/skyadb/ui/components/AppStatusBadge.kt
• app/src/main/java/com/sky22333/skyadb/ui/device/DeviceScreen.kt
• app/src/main/java/com/sky22333/skyadb/ui/device/DeviceViewModel.kt
• app/src/main/java/com/sky22333/skyadb/ui/diagnostics/DiagnosticLogScreen.kt
• app/src/main/java/com/sky22333/skyadb/ui/discovery/DeviceDiscoveryScreen.kt
• app/src/main/java/com/sky22333/skyadb/ui/discovery/DeviceDiscoveryViewModel.kt
• app/src/main/java/com/sky22333/skyadb/ui/download/OnlineDownloadScreen.kt
• app/src/main/java/com/sky22333/skyadb/ui/download/OnlineDownloadViewModel.kt
• app/src/main/java/com/sky22333/skyadb/ui/files/FileTransferScreen.kt
• app/src/main/java/com/sky22333/skyadb/ui/files/FileTransferViewModel.kt
• app/src/main/java/com/sky22333/skyadb/ui/home/HomeScreen.kt
• app/src/main/java/com/sky22333/skyadb/ui/home/HomeViewModel.kt
• app/src/main/java/com/sky22333/skyadb/ui/install/InstallApkScreen.kt
• app/src/main/java/com/sky22333/skyadb/ui/install/InstallApkViewModel.kt
• app/src/main/java/com/sky22333/skyadb/ui/localapps/LocalAppsScreen.kt
• app/src/main/java/com/sky22333/skyadb/ui/localapps/LocalAppsViewModel.kt
• app/src/main/java/com/sky22333/skyadb/ui/logs/SystemLogScreen.kt
• app/src/main/java/com/sky22333/skyadb/ui/logs/SystemLogViewModel.kt
• app/src/main/java/com/sky22333/skyadb/ui/mirror/MirrorScreen.kt
• app/src/main/java/com/sky22333/skyadb/ui/mirror/MirrorViewModel.kt
• app/src/main/java/com/sky22333/skyadb/ui/pairing/PairingScreen.kt
• app/src/main/java/com/sky22333/skyadb/ui/pairing/PairingViewModel.kt
• app/src/main/java/com/sky22333/skyadb/ui/remote/RemoteControlScreen.kt
• app/src/main/java/com/sky22333/skyadb/ui/remote/RemoteControlViewModel.kt
• app/src/main/java/com/sky22333/skyadb/ui/screenshot/ScreenshotScreen.kt
• app/src/main/java/com/sky22333/skyadb/ui/screenshot/ScreenshotViewModel.kt
• app/src/main/java/com/sky22333/skyadb/ui/settings/SettingsScreen.kt
• app/src/main/java/com/sky22333/skyadb/ui/settings/SettingsViewModel.kt
• app/src/main/java/com/sky22333/skyadb/ui/shell/ShellScreen.kt
• app/src/main/java/com/sky22333/skyadb/ui/shell/ShellViewModel.kt
• app/src/main/java/com/sky22333/skyadb/usb/UsbBulkChannel.kt
• app/src/main/java/com/sky22333/skyadb/validation/DevicePathValidator.kt
• app/src/main/java/com/sky22333/skyadb/validation/DownloadInputValidator.kt
• app/src/main/java/com/sky22333/skyadb/validation/NetworkInputValidator.kt
• app/src/main/res/values-v27/styles.xml
• app/src/main/res/values-zh-rCN/strings.xml
• app/src/main/res/values/colors.xml
• app/src/main/res/values/strings.xml
• app/src/main/res/values/styles.xml
• app/src/main/res/xml/locales_config.xml
• app/src/test/java/com/sky22333/skyadb/adb/FastbootOtgManagerTest.kt
• app/src/test/java/com/sky22333/skyadb/apps/AppDisplayEnricherTest.kt
• app/src/test/java/com/sky22333/skyadb/diagnostics/DiagnosticLoggerTest.kt
• app/src/test/java/com/sky22333/skyadb/discovery/AdbMdnsDiscoveryTest.kt
• app/src/test/java/com/sky22333/skyadb/discovery/ScanRangeParserTest.kt
• app/src/test/java/com/sky22333/skyadb/scrcpy/MirrorQualityPresetTest.kt
• app/src/test/java/com/sky22333/skyadb/scrcpy/ScrcpyProtocolTest.kt
• app/src/test/java/com/sky22333/skyadb/ui/remote/RemoteKeyTest.kt
• app/src/test/java/com/sky22333/skyadb/validation/DevicePathValidatorTest.kt
• app/src/test/java/com/sky22333/skyadb/validation/DownloadInputValidatorTest.kt
• app/src/test/java/com/sky22333/skyadb/validation/NetworkInputValidatorTest.kt
• docs/README.md
• gradle/libs.versions.toml

---

📝 Walkthrough

Walkthrough

This change adds AppCompat locale support, English and Simplified Chinese resources, localized application text, improved app labels and icons, and updated scrcpy 4.1 mirroring with surface recreation support.

Changes

Application localization and platform support

Layer / File(s)	Summary
Localization foundation and resource catalog app/src/main/java/.../i18n/*, app/src/main/res/values*/strings.xml, app/src/main/AndroidManifest.xml, gradle/libs.versions.toml	Adds AppCompat locale support, AppLanguage, AppText, English and Chinese resources, and resource-backed model and validation contracts.
Localized backend and Compose flows app/src/main/java/.../adb/*, .../discovery/*, .../download/*, .../files/*, .../ui/*	Replaces hardcoded Chinese labels and messages with localized resources across ADB, discovery, downloads, file operations, diagnostics, and screens.
Application labels and icons app/src/main/java/.../apps/*, app/src/main/java/.../ui/apps/*	Resolves local application labels, caches them, sorts enriched app data, and loads device application icons.
Scrcpy session lifecycle app/src/main/java/.../scrcpy/*, app/src/main/assets/scrcpy/scrcpy-server-v4.1	Updates scrcpy to 4.1 and adds surface replacement, reset-video packets, keyframe handling, asynchronous audio setup, and concurrent mirror connections.
Validation and regression coverage app/src/test/java/.../*	Updates tests for resource-backed values and adds coverage for Fastboot response statuses, application labels, and reset-video packets.

Estimated code review effort: 4 (Complex) | ~60 minutes

Possibly related PRs

• sky22333/skyadb#7: Introduced the scrcpy mirroring classes and APIs updated here.
• sky22333/skyadb#14: Modified the same mirror connection and session handling components.
• sky22333/skyadb#29: Introduced the Fastboot OTG integration points updated here.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch dev

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}