Skip to content

[Core] Glob status no longer reports managed clusters as not found - #11457

Merged
DanielZhangQD merged 1 commit into
masterfrom
glob-status-managed
Nov 20, 2026
Merged

DanielZhangQD merged 1 commit into
masterfrom
glob-status-managed

Conversation

@DanielZhangQD

@DanielZhangQD DanielZhangQD commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • sky status 'p*' / sky down 'p*' printed Cluster(s) not found: ... for managed-job and pool-worker clusters whose names matched the pattern. Glob expansion did not filter managed clusters, but the record lookup that follows does, so those names were reported as missing.
  • The glob expansion now applies the same exclude_managed_clusters filter as the lookup. With _include_is_managed or SKYPILOT_DEBUG=1, managed clusters still match.

Test plan

  • Unit: pytest tests/unit_tests/test_backend_utils.py -k glob_does_not (real SQLite state DB, one regular and one managed cluster, both arms of _include_is_managed). It fails on master: the regular-only arm logs the managed cluster as not found.
  • Manual:
    sky jobs launch -y -d -n gtest-job --cpus 0.1+ sleep 600
    sky jobs pool apply -y -p gtest-pool pool.yaml   # any 1-worker pool
    sky launch -y -c gtest-own --cpus 0.1+
    sky status 'gtest-*'
    Before: Cluster(s) not found: gtest-job-<id>, gtest-pool-1. above the table. After: no such line; the table lists gtest-own only.

🤖 Generated with Claude Code


Devin Review

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@DanielZhangQD
DanielZhangQD requested a review from aylei November 20, 2026 07:08
@DanielZhangQD

Copy link
Copy Markdown
Collaborator Author

/quicktest-core --kubernetes --base-branch master

@aylei aylei left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DanielZhangQD !

@DanielZhangQD
DanielZhangQD merged commit f7fa8da into master Nov 20, 2026
29 of 30 checks passed
@DanielZhangQD
DanielZhangQD deleted the glob-status-managed branch November 20, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants