Skip to content

feat: add webapi response changes as of 2026-05-13#1588

Open
slackapi[bot] wants to merge 2 commits into
mainfrom
api
Open

feat: add webapi response changes as of 2026-05-13#1588
slackapi[bot] wants to merge 2 commits into
mainfrom
api

Conversation

@slackapi
Copy link
Copy Markdown
Contributor

@slackapi slackapi Bot commented May 13, 2026

This PR updates the web API client and model based on the production E2E test results.

Category

  • slack-api-model (Slack API Data Models)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@slackapi slackapi Bot requested a review from a team as a code owner May 13, 2026 09:10
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.20%. Comparing base (c636708) to head (00301d1).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1588      +/-   ##
============================================
+ Coverage     73.17%   73.20%   +0.02%     
- Complexity     4513     4515       +2     
============================================
  Files           477      477              
  Lines         14291    14291              
  Branches       1488     1488              
============================================
+ Hits          10458    10462       +4     
+ Misses         2940     2938       -2     
+ Partials        893      891       -2     
Flag Coverage Δ
jdk-14 73.20% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zimeg
Copy link
Copy Markdown
Member

zimeg commented May 13, 2026

👾 Eek! A few polish needed but an alright start @slackapi[bot]!

@zimeg zimeg marked this pull request as draft May 13, 2026 09:19
@zimeg
Copy link
Copy Markdown
Member

zimeg commented May 13, 2026

🗣️ Am wanting to revisit this soon with request and response arguments too but I will sleep on an approach toward this-

Add missing properties detected during remote API tests:
- is_modified_by_ai to File and MatchedItem models
- slack_file_id to Attachment model

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg zimeg added project:slack-api-model project:slack-api-model semver:patch labels May 13, 2026
@zimeg zimeg self-assigned this May 13, 2026
@zimeg zimeg modified the milestone: 1.48.2 May 13, 2026
Copy link
Copy Markdown
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟 Words after inspecting these changes-

private boolean canvasPrintingEnabled;

private boolean isAiSuggested;
private boolean isModifiedByAi;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👾 note: True!

Copy link
Copy Markdown
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😉 With generous self approval too!

@zimeg zimeg marked this pull request as ready for review May 13, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant