Remove Parcelable supertype from Screen and PopResult - #2849
Open
ZacSweers wants to merge 13 commits into
Open
Conversation
stagg
reviewed
Aug 14, 2026
|
|
||
| public actual val DefaultCircuitSaver: CircuitSaver = AndroidDefaultCircuitSaver | ||
|
|
||
| private object AndroidDefaultCircuitSaver : CircuitSaver() { |
Collaborator
There was a problem hiding this comment.
Think I'm almost fine with this staying as PassThroughCircuitSaver?
Seeing how dropping Parcelable from Screen is a breaking change, and folks will need to opt back in by adding Parcelable or ParcelableScreen, it might be fine to require folks to explicitly set a ParcelableCircuitSaver?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This completes the migration away from requiring parcelable on screens and popresults!
The one thing I'm not super stoked on is the behavior of
DefaultCircuitSaveron androidMain, open to suggestions here. Tried to documented it well.