Refactor microphonics plots to use shared PlotTooltip utility#198
Open
hmarts9 wants to merge 4 commits into
Open
Refactor microphonics plots to use shared PlotTooltip utility#198hmarts9 wants to merge 4 commits into
hmarts9 wants to merge 4 commits into
Conversation
s-aderhold
approved these changes
May 12, 2026
Contributor
There was a problem hiding this comment.
Why does the spectrogram plot only remove the specific tooltip, but not add the new shared tooltip?
Contributor
Author
There was a problem hiding this comment.
The spectrogram uses a grid of separate sub plots for each cavity so the shared PlotTooltip can't just attach to it like the other plots. Also it already has the colorbar for power values and it's more about looking at patterns than reading individual points so I didn't think a tooltip would really add much here. I can look into adding one though if you think we need it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors all microphonics plot classes to use the shared PlotTooltip utility instead of custom tooltip implementations.