feat(cli): add kimi and qwen presets to happy acp - #1752
Open
taiyiops wants to merge 1 commit into
Open
Conversation
Kimi Code CLI exposes ACP via `kimi acp`, Qwen Code via `qwen --acp`. Users currently have to spell the full command form (`happy acp -- kimi acp`); this adds the two aliases next to gemini/opencode so `happy acp kimi` and `happy acp qwen [args]` work, with passthrough args preserved. Tests updated. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01QBfUsLSj8DBVvVmHSqCDqZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
happy acpships presets forgeminiandopencode, but Kimi Code CLI (kimi acp) and Qwen Code (qwen --acp) both speak ACP too, so users have to spell the long form (happy acp -- kimi acp). This PR addskimiandqwentoKNOWN_ACP_AGENTSsohappy acp kimi/happy acp qwen [args]just work, with passthrough args preserved. No behavior change for existing aliases.Proof
resolveAcpAgentConfigon this branch (run with tsx):The target commands exist as documented by the vendors (Kimi Code CLI 0.39.1 on my machine):
Qwen Code's flag is
--acp(also accepts--experimental-acp).Unit tests (
packages/happy-cli,vitest run --project unit src/agent/acp/acpAgentConfig.test.ts): 9 passed, including new cases for both presets.tsc --noEmitclean.Notes
happy acp kimifrom a self-hosted happy server on a daily basis via the--form today, this only shortens it.🤖 Generated with Claude Code
https://claude.ai/code/session_01QBfUsLSj8DBVvVmHSqCDqZ