Repository navigation
fix(ci): drop runner.temp from the ClawHub job's env - #31
Merged
Merged
Conversation
The workflow failed to parse, so every event on it died in seconds and a release
could not be published at all:
HTTP 422 failed to parse workflow: (Line: 183, Col: 28): Unrecognized
named-value: 'runner'
A job-level `env:` may reference only the `secrets` and `vars` contexts, so
`${{ runner.temp }}` there invalidates the whole file, not just the step. GitHub
reported it on the dispatch call rather than as a job failure, and the last
release predates the line — introduced by b795569 while reworking the ClawHub
steps, with no tag pushed since — so nothing exercised it until the 0.7.0
rehearsal. The recent run list shows the blast radius: ten consecutive
publish.yml failures, each ~0 seconds.
The variable was dead: no step in the repository reads CLAWHUB_CONFIG_PATH, so
deleting the line is the whole fix. Had a step needed the path, the runner
already exports RUNNER_TEMP inside steps.
|
Sorry @modusensus, you've used your own review budget of 250,000 diff characters for the last 7 days. You can request another review in 5 days and 1 hour by commenting |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves the unused Flow diagram for the corrected publish workflowflowchart TD
Dispatch[Workflow dispatch] --> Parse[Parse publish.yml]
Parse --> Preflight[Preflight job]
Preflight --> Publish[Publish job]
Publish --> Conditions{Tag push or publish input}
Conditions -->|false| Skip[ClawHub skipped]
Conditions -->|true| ClawHub[ClawHub job]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the 0.7.0 release rehearsal, not by a release:
publish.ymldid not parse, so the release path has been dead since PR #23 landed.A job-level
env:may reference only thesecretsandvarscontexts, so${{ runner.temp }}there invalidates the whole file. GitHub reports it on the dispatch call instead of as a job failure, which is why it stayed invisible:b795569added the line while reworking the ClawHub steps, no tag has been pushed since, and every other workflow in the repo is unaffected.The blast radius, from the run list — ten consecutive
publish.ymlfailures, each about 0 seconds:The fix
One line deleted.
CLAWHUB_CONFIG_PATHis read by no step anywhere in the repository (grep -rn CLAWHUB_CONFIG_PATH→ the definition itself, nothing else), so removing it is the whole change. Had a step needed the path,RUNNER_TEMPis already exported inside steps.Verified by running it
Re-dispatched the rehearsal on this branch — accepted, and green:
clawhubskipping is correct for a rehearsal: itsifrequires a tag push orinputs.publish == true, as do thePublishandCreate the GitHub releasesteps — I read each condition before dispatching anything. The publish job ran the suite, the already-on-npm gate, the notes render andnpm publish --dry-run.What this does not prove
That
CLAWHUB_TOKENholds a non-empty value. preflight only fails on an empty token whenreleasing=true, and in a rehearsal it just recordsabsent; the runner loggedSet output 'clawhub-token'without the value, andgh secret listshowing the name (last updated 2026-09-23) is the exact signal that was already proven misleading. Thepublishjob'sneeds: preflightmeans a real tag push with an empty token stops before anything ships, so the next release will answer it — at the cost of one failed run, not a half-published version.Summary by Sourcery
Bug Fixes: