feat(dxfeed): use NumericResultEndpoint for price endpoint - #5299
Open
danwilliams-cll wants to merge 3 commits into
Open
feat(dxfeed): use NumericResultEndpoint for price endpoint#5299danwilliams-cll wants to merge 3 commits into
danwilliams-cll wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: 3c85180 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Switches the price endpoint from AdapterEndpoint to NumericResultEndpoint for automatic numeric result validation.
danwilliams-cll
force-pushed
the
feat/dxfeed-numeric-result-endpoint
branch
from
August 14, 2026 16:40
c62f374 to
7c97fd6
Compare
danwilliams-cll
marked this pull request as ready for review
August 14, 2026 17:53
Adds tests verifying the dxfeed price endpoint returns 502 for non-numeric provider results and that the existing success path still works.
Adds a changeset for the dxfeed price endpoint NumericResultEndpoint migration.
danwilliams-cll
force-pushed
the
feat/dxfeed-numeric-result-endpoint
branch
from
August 14, 2026 18:12
e6b103e to
3c85180
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the dxfeed price endpoint to use the framework's generic
NumericResultEndpointfor automatic numeric result validation.Changes
AdapterEndpointwithNumericResultEndpoint<BaseEndpointTypes>insrc/endpoint/price.ts.Local verification
ea-framework-jsvia yarnportal:and ran the dxfeed test suite: 21 tests passed.Dependency
This PR requires a framework release containing the generic
NumericResultEndpoint(smartcontractkit/ea-framework-js#876). Thepackage.jsondependency will be bumped to that release version once it is available.