Add fallback thumbnail SVG for missing project thumbnails#471
Open
superconductor-for-github[bot] wants to merge 1 commit into
Open
Add fallback thumbnail SVG for missing project thumbnails#471superconductor-for-github[bot] wants to merge 1 commit into
superconductor-for-github[bot] wants to merge 1 commit into
Conversation
A 160x120 placeholder rendered in Berkeley blue (#003262) when a project has no stored thumbnail and one can't be regenerated from its XML. Intended to be wired up to the listing/render paths so a single broken project no longer leaves an empty <img> on the page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
static/img/missing-thumbnail.svg, a 160x120 placeholder in Berkeley blue (#003262) for use anywhere a project thumbnail can't be served.Test plan
static/img/missing-thumbnail.svgis served by nginx (curl https://<host>/static/img/missing-thumbnail.svg).