Skip to content

fix(query): stamp preload entry adoption once (#739) - #740

Closed
jaroel wants to merge 1 commit into
solidjs:mainfrom
jaroel:fix/739-preload-entry-adoption-rerun
Closed

jaroel wants to merge 1 commit into
solidjs:mainfrom
jaroel:fix/739-preload-entry-adoption-rerun

Conversation

@jaroel

@jaroel jaroel commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Fixes #739.

This is AI generated and I have no idea if this is the right approach or if this happens to work just for me.

A navigate read that adopts a preload-intent cache entry re-stamped cached[0] on every read and published it into the entry version signal, so subscribers re-ran, read again, and re-ran again (ABANDONED_FLIGHTS). Adopt the entry once and stamp that adoption; later reads of the same promise write the same value.
@changeset-bot

changeset-bot Bot commented Nov 17, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 49e99f0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Member

Thanks for the report and the fix! We merged #742, which fixes the same bug and also writes the stamp before the read tracks it, so the reading memo never notifies itself. Your regression test is in #743, credited to you.


Generated by Claude Code

@ryansolid ryansolid closed this Nov 20, 2026
ryansolid added a commit that referenced this pull request Nov 20, 2026
…ce (#739) (#743)

Regression test from #740. It fails before #742 (the memo ran 5 times)
and passes after it.



Claude-Session: https://claude.ai/code/session_0117BoWMR7ndYUnqBW5NjTbC

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Roel Bruggink <roel@jaroel.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[2.0.0] query(): adopting a preload entry re-stamps the version signal on every read and re-runs subscribers

2 participants